ci: wait out npm's publish-time malware scan - #2225
Merged
Merged
Conversation
siddsriv
approved these changes
Aug 11, 2026
Contributor
Author
|
Last release published only three versions, none of which had to wait for malware scanning to complete. It did refresh the six versions which missed in the record though. ✅ Recorded 62 of 62 publishable package(s) as published on npm (9 newly verified via registry) in /home/runner/work/_temp/published-packages/record.json.Logs: https://github.com/smithy-lang/smithy-typescript/actions/runs/31624774326/job/94208252745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.blog/changelog/2026-07-28-npm-publish-time-malware-scanning-and-dual-use-metadata/
Noticed in previous run logs where six versions weren't done by malware scanning, and thus not visible on npm view
Details: https://github.com/smithy-lang/smithy-typescript/actions/runs/31518075558/job/93868079304
Description of changes:
npm now scans every publish for malware before making the version installable, so for several minutes after a release the registry answers 404 for versions it did publish, indistinguishable from versions never published at all.
The record refresh runs inside that window, so it would record none of what the release just published and leave every check on the next release PR falling back to the registry. It now re-checks anything the registry does not have yet until it appears or a 25 minute budget runs out (
NPM_PUBLISH_SCAN_WAIT_MSoverrides it, 0 to skip waiting), with the workflow job capped at 40 minutes so a hang is cut short. The existence check's failure message now tells maintainers to re-run before treating a fresh release's versions as lost.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.