Skip to content

[SSP]Returning tenantId of buckets when listing out the buckets#1308

Open
vineela1999 wants to merge 2 commits into
sodafoundation:masterfrom
vineela1999:adminSSP
Open

[SSP]Returning tenantId of buckets when listing out the buckets#1308
vineela1999 wants to merge 2 commits into
sodafoundation:masterfrom
vineela1999:adminSSP

Conversation

@vineela1999

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation

kind enhancement

What this PR does / why we need it:
This PR is required to give tenantId of each buckets when listing down the buckets
To implement the usecase that When Admin is trying to list buckets buckets created by buckets should only have operations
Non-admin user created buckets should only be in read mode
Which issue(s) this PR fixes:

Fixes #1297 (bucket visibility of admin)

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

kind TESTED

/kind NOT-TESTED

Test Report:

Now,list buckets is showing tenantID of each bucket:
Screenshot from 2021-08-31 21-39-37

Special notes for your reviewer:

@codecov

codecov Bot commented Aug 31, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1308 (6b6a1cd) into master (bb06780) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1308   +/-   ##
=======================================
  Coverage   48.12%   48.12%           
=======================================
  Files          10       10           
  Lines        1571     1571           
=======================================
  Hits          756      756           
  Misses        756      756           
  Partials       59       59           

@rajat-soda rajat-soda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PravinRanjan10

Copy link
Copy Markdown
Collaborator

LGTM

@PravinRanjan10 PravinRanjan10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks anvithks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vineela1999 The response already has a <Owner></Owner> tag.
This tag refers to the owner of the buckets.
Now if a tenantId is returned as part of the bucket metadata will this <Owner> tag still be returned?

@vineela1999

Copy link
Copy Markdown
Contributor Author

@anvithks OwnerID here is used in the sense who requested for list buckets and each tenantId is who created the bucket

@anvithks

anvithks commented Sep 3, 2021

Copy link
Copy Markdown
Member

@anvithks OwnerID here is used in the sense who requested for list buckets and each tenantId is who created the bucket

@vineela1999 Owner in response to a GET buckets call will mean the owner of the bucket.
In the current API it refers to the owner of the bucket as the API does not return the ownerID per bucket but for all buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SSP] Sanity of SSP Feature

4 participants