Skip to content

handle improper accesses to /redirect_genome_browser gracefully #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
croth1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle improper accesses to /redirect_genome_browser gracefully #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion bammmotif/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,24 @@ def run_genome_browser(request):
form = GenomeBrowserForm(request.POST)

if not form.is_valid():
logger.error('programming error: form should always be valid here.')
raw_job_id = form['job_id'].data
raw_motif_id = form['motif_id'].data
raw_organism = form['organism'].data
raw_assembly_id = form['assembly_id'].data

# this is not a redirect from our results page
if raw_job_id is None:
return HttpResponse(status=404)
else:
logger.error(
'GenomeBrowser form did not validate:'
' job_id: %s,'
' motif_id: %s,'
' organism: %s,'
' assembly: %s',
raw_job_id, raw_motif_id, raw_organism, raw_assembly_id
)

return HttpResponse(status=500)

job_id = form.cleaned_data['job_id']
Expand Down