[FEM.Elastic] Remove complex unproductive stiffness matrix data structure#6133
Open
alxbilger wants to merge 3 commits into
Open
[FEM.Elastic] Remove complex unproductive stiffness matrix data structure#6133alxbilger wants to merge 3 commits into
alxbilger wants to merge 3 commits into
Conversation
alxbilger
added
pr: enhancement
Contributor
|
@alxbilger did you run benchmarks on this branch vs master ? |
Contributor
|
[ci-build][with-all-tests] |
Contributor
Author
|
@fredroy For now, I tested with https://github.com/alxbilger/Elasticity/blob/master/benchmark/python/run_tetra.py and it speed it up |
Contributor
|
on macOS on M3Pro ( 12 P + 4E cores)
Linux on i7 13700K ( 8 P + 8E cores)
Those numbers are virtually identical to those in #6069 so I guess we can close it |
fredroy
approved these changes
Jun 1, 2026
Contributor
|
By the way: Windows/MSVC 2026 (Core i7-11800H @ 2.30GHz)
|
Contributor
|
I rebased the CUDA implementation (#6071) on this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6069, it is suspected that the
ElementStiffnessMatrixdata structure did not achieve its performance objectives. It was suggested to replace it by a simple matrix, and contain them in a vector.This new PR applies the suggestion, and removes totally the complex data structure, that is no longer used.
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if