modify updated markers during upload#6171
Open
ClayBirkett wants to merge 2 commits into
Open
Conversation
Member
Author
|
The previous code lib/SGN/Controller/AJAX/GenotypesVCFUpload) iterates over every key in the uploaded marker's $new_marker_details hash and compares each one against the same key in the stored marker. So the fields compared are whatever keys happen to be present in the new marker data hash for each marker. Typically, for a CXGN::Genotype::Protocol marker, these would include things like chrom, pos, alt, ref, qual, filter, and info — but the code itself is field-agnostic and will compare whatever is there. In this code I have limited it to chrom, pos, alt, ref. |
titima15
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If markers are changed (for example the alt field) then provide option to update existing protocol
fixes #6167
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.