Cleanup pass + add Addresses.removeAddress - #99
Merged
Merged
Conversation
Signed-off-by: Elliot <elliotfriedman3@gmail.com>
Implements removeAddress/resetRemovedAddresses/getRemovedAddresses on Addresses and IAddresses, mirroring the existing add/change tracking pattern. This gives callers a way to undo address entries (and the corresponding entry in the on-disk json via updateJson()). test_checkAddressFileUpdate now calls removeAddress + updateJson() as teardown so it no longer permanently writes its TEST1/TEST2/TEST3 fixtures into the committed addresses/*.json files, which was causing it to fail on repeat runs with "Address with name: TEST1 already set on chain: 11155111". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The project's LICENSE and README both declare Forge Proposal Simulator as MIT licensed, but several files carried GPL-3.0-or-later or BSD-3-Clause SPDX headers (or none at all). Normalize every non-vendored .sol file to MIT to match the project's actual, declared license and make it fully permissive/open source. Vendored dependencies under lib/ are untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrossChainProposal.sol, alphabetizes/reformats several files) — prior commits on this branch.removeAddress(+resetRemovedAddresses/getRemovedAddresses) toAddresses/IAddresses, mirroring the existing add/change tracking pattern, so entries can be removed from the registry and the on-disk json.test_checkAddressFileUpdate, which was failing withAddress with name: TEST1 already set on chain: 11155111. Root cause: the test callsupdateJson(), which writes straight to the realaddresses/*.jsonfiles (no sandboxing), so itsTEST1/TEST2/TEST3fixtures were being permanently baked into the committed files on every run, breaking the next run. The test now callsremoveAddress+updateJson()as teardown to undo its own writes.Test plan
forge build— compiles cleanlyforge test— 62/62 passing, includingtest_checkAddressFileUpdatere-run twice back-to-back with no leftover state inaddresses/*.jsonremoveAddresssuccess/revert paths andgetRemovedAddresses/resetRemovedAddresses🤖 Generated with Claude Code