Skip to content

Use sonic-ext:custom-validation as complexed logical range resolution.#6

Merged
jjin62 merged 1 commit into
otn-devfrom
exp/otn-dev_dynamic-range
May 8, 2026
Merged

Use sonic-ext:custom-validation as complexed logical range resolution.#6
jjin62 merged 1 commit into
otn-devfrom
exp/otn-dev_dynamic-range

Conversation

@dudu579

@dudu579 dudu579 commented May 4, 2026

Copy link
Copy Markdown

Solution for the other two use cases

  • Identity/enum: Directly write sonic-mgmt-common sonic-yang.
  • Dynamic range/complexed logic: Directly extended sonic-yang though sonic-ext:custom-validation.

@dudu579 dudu579 linked an issue May 4, 2026 that may be closed by this pull request

@jjin62 jjin62 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check target-gain against configured min-gain and max-gain value

Comment thread models/yang/sonic/sonic-optical-amplifier.yang
@dudu579 dudu579 force-pushed the exp/otn-dev_dynamic-range branch 2 times, most recently from 39081c5 to 0c920d0 Compare May 8, 2026 00:33
- Introduce sonic-ext:custom-validation to support component-specific dynamic range validation
- Add additional identities to extend amplifier type coverage
- Use target-gain as a reference example for dynamic range enforcement
- Exclude src/sonic-yang-models/common since sonic-mgmt-common already has sonic-extension.yang. Cause import conflicts
@dudu579 dudu579 force-pushed the exp/otn-dev_dynamic-range branch from 0c920d0 to b9c6c80 Compare May 8, 2026 00:37
@dudu579 dudu579 changed the base branch from feat/otn-dev_range-extension to otn-dev May 8, 2026 00:38
@dudu579 dudu579 self-assigned this May 8, 2026
Comment thread tools/pyang/import_yang.py
@jjin62 jjin62 merged commit 4f4d676 into otn-dev May 8, 2026
@jjin62 jjin62 deleted the exp/otn-dev_dynamic-range branch May 8, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Value validaions

2 participants