[broadcom] Bump legacy-th SAI to 13.2.1.120 (OCP 1.18.1 compat)#27875
Open
lipxu wants to merge 1 commit into
Open
[broadcom] Bump legacy-th SAI to 13.2.1.120 (OCP 1.18.1 compat)#27875lipxu wants to merge 1 commit into
lipxu wants to merge 1 commit into
Conversation
Update the Broadcom legacy-th (Tomahawk) SAI to the rebuild against the latest OCP SAI 1.18.1 header, matching the SONiC master SAI header. - LIBSAIBCM_LEGACY_TH_VERSION: 13.2.1.100 -> 13.2.1.120 - LIBSAIBCM_LEGACY_TH_BRANCH_NAME: SAI_13.2.1_compat_OCP1.17.1 -> SAI_13.2.1_compat_OCP1.18.1 Signed-off-by: Liping Xu <108326363+lipxu@users.noreply.github.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Broadcom legacy Tomahawk (legacy-th) SAI package pin so the built image pulls a SAI binary rebuilt against the newer OCP SAI 1.18.1 headers, keeping syncd/sairedis ABI/API compatibility for legacy-th platforms.
Changes:
- Bumped
LIBSAIBCM_LEGACY_TH_VERSIONfrom13.2.1.100to13.2.1.120. - Updated
LIBSAIBCM_LEGACY_TH_BRANCH_NAMEtoSAI_13.2.1_compat_OCP1.18.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The Broadcom Tomahawk (legacy-th) SAI is the old official TH SAI rebuilt against the latest OCP SAI header to stay ABI/API-compatible with SONiC's user-space SAI (syncd/sairedis).
SONiC master's OCP SAI header has advanced to 1.18.1 (sairedis → OCP/SAI submodule
saiversion.h:SAI_MAJOR=1, SAI_MINOR=18, SAI_REVISION=1). The previous legacy-th binary (13.2.1.100, compat tierOCP1.17.1) no longer matches the headersyncdis built against, so the TH SAI was rebuilt to the new compat tier:13.2.1.120/SAI_13.2.1_compat_OCP1.18.1.How I did it
Updated
platform/broadcom/sai-legacy-th.mk:LIBSAIBCM_LEGACY_TH_VERSION:13.2.1.100→13.2.1.120LIBSAIBCM_LEGACY_TH_BRANCH_NAME:SAI_13.2.1_compat_OCP1.17.1→SAI_13.2.1_compat_OCP1.18.1No other files require changes: the
docker-syncd-brcm-legacy-thimage is variable-driven (consumesBRCM_LEGACY_TH_SAIautomatically), and thesaibcm-modules-legacy-thkernel driver is tied to the Broadcom SDK, not the OCP SAI header.How to verify it
Installed the resulting
sonic-aboot-broadcom-legacy-th.swion Arista 7060CX-32S hardware and confirmed a clean boot.syncdinitializes with the new binary:libsaibcm 13.2.1.120installed;libsai.soloaded; all containers up; 32 interfaces oper-up; BGP established with full route table.Which release branch to backport (provide reason below if selected)
Description for the changelog
[broadcom] Bump legacy-th SAI to 13.2.1.120 (OCP 1.18.1 compatibility tier)