Add EVPN MH handlers in frrcfgd#27885
Open
rakshitha-marvell wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rakshitha SK <rsk@marvell.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
no unit test? |
Contributor
|
Thanks for the update — overall this looks good and CI is green ✅ One request before merge: could you please add (or point to) unit tests for the new EVPN-MH handling paths in Suggested minimum coverage:
This would make the change safer against regressions since the logic is config-branch heavy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
SONiC's frrcfgd had no handling for EVPN Multihoming (MH) configuration. This change adds support so that EVPN-MH can be configured through ConfigDB and rendered into FRR:
Work item tracking
How I did it
Type-0: applies the explicit ESI via evpn mh es-id .
Type-3: derives es-id (falling back to the interface port number) and es-sys-mac (falling back to the PORTCHANNEL system_mac), then applies them.
How to verify it
On a device, configure an Ethernet Segment and global MH timers in ConfigDB and confirm the corresponding evpn mh ... commands appear in the FRR running config (vtysh -c 'show running-config').
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)