Changes to accept SSH/SNMP/Telemetry from GIL IP for multi-asic platforms#398
Merged
abdosi merged 2 commits intoJun 23, 2026
Merged
Conversation
…orms For multi-asic platforms, add FORWARD chain iptables rules to allow SSH/SNMP/Telemetry connections from the GIL (Global In-band Link) IP (namespace management IP) in non-default namespaces. Also adds FORWARD chain DROP rules to block other forwarded traffic when control plane ACLs are configured. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add unit tests covering the three changes introduced for multi-asic GIL IP ACL support in caclmgrd: 1. GIL FORWARD ACCEPT rules: Verify FORWARD ACCEPT rules are generated from namespace_mgmt_ip/ipv6 for SSH and SNMP (multi_asic_ns_to_host_fwd=True) in non-default namespaces, and NOT for NTP (multi_asic_ns_to_host_fwd=False). 2. ACL FORWARD chain: Verify SSH/SNMP ACL rules use FORWARD chain in non-default namespaces, while NTP still uses INPUT. 3. FORWARD DROP: Verify FORWARD DROP rules are appended in non-default namespaces when ctrl-plane ACL rules exist. 4. Default namespace regression: Verify SSH uses INPUT chain and no FORWARD DROP is added for the default namespace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For multi-asic platforms, add
FORWARDchain iptables rules to allow SSH/SNMP/Telemetry connections from the GIL (Global In-band Link) IP (namespace management IP) in non-default namespaces.Changes
FORWARDACCEPT rules sourced fromnamespace_mgmt_ip/namespace_mgmt_ipv6for each ACL service withmulti_asic_ns_to_host_fwd=Truein non-default namespacesINPUTtoFORWARDfor non-default namespace services withmulti_asic_ns_to_host_fwd=TrueFORWARDDROP rules in non-default namespaces when control plane ACLs are configuredMotivation
On multi-asic chassis platforms, connections from the GIL IP are forwarded through the namespace network stack rather than directly received as INPUT, so FORWARD chain rules are needed to allow and restrict these connections properly.