Skip to content

[agent][ssd] Fix NameError: nand_endurance undefined in parse_micron_info() #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rustiqly wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[agent][ssd] Fix NameError: nand_endurance undefined in parse_micron_info() #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3620a1e
[agent][ssd] Fix NameError: nand_endurance undefined in parse_micron_…
rustiqly Mar 25, 2026
3578341
Add Micron NAND endurance health unit test
rustiqly May 11, 2026
43036a4
Fix Micron NAND endurance fallback parsing
rustiqly May 11, 2026
75ef227
Fix Micron NAND endurance SMART parsing
rustiqly May 11, 2026
70efdf5
Fix Virtium SSD health regression
rustiqly May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sonic_platform_base/sonic_storage/ssd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,11 @@ def parse_micron_info(self):

if health_raw == NOT_AVAILABLE:
average_erase_count = self.parse_id_number(MICRON_AVG_ERASE_COUNT_ID, self.vendor_ssd_info)
erase_fail_count = self.parse_id_number(MICRON_ERASE_FAIL_COUNT_ID, self.vendor_ssd_info)
nand_endurance = self._parse_re(r'(?m)NAND_Endurance.*?(\d+)\s*$', self.vendor_ssd_info)

if average_erase_count != NOT_AVAILABLE and erase_fail_count != NOT_AVAILABLE:
if average_erase_count != NOT_AVAILABLE and nand_endurance != NOT_AVAILABLE:
try:
self.health = 100 - (float(average_erase_count) * 100 / float(nand_endurance))
self.health = 100 - (float(average_erase_count.split()[-1]) * 100 / float(nand_endurance))
except (ValueError, ZeroDivisionError) as ex:
self.log.log_info("SsdUtil parse_micron_info exception: {}".format(ex))
pass
Expand Down
13 changes: 13 additions & 0 deletions tests/test_ssd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,6 +1951,19 @@ def test_micron_ssd(self):
assert(micron_ssd.get_disk_io_writes() == '9607694422')
assert(micron_ssd.get_reserved_blocks() == '475')

def test_micron_ssd_health_from_nand_endurance(self):
micron_output = output_micron_ssd.replace(
"202 Percent_Lifetime_Used 0x0031 075 075 000 Pre-fail Offline - 25\n",
"202 Unknown_Attribute 0x0031 075 075 000 Pre-fail Offline - 25\n"
"999 NAND_Endurance 0x0032 100 100 000 Old_age Always - 3028\n"
)

with mock.patch('sonic_platform_base.sonic_storage.ssd.SsdUtil._execute_shell',
mock.MagicMock(return_value=micron_output)):
micron_ssd = SsdUtil('/dev/sda')

assert micron_ssd.get_health() == 75.0


@mock.patch('sonic_platform_base.sonic_storage.ssd.SsdUtil._execute_shell', mock.MagicMock(return_value=output_intel_ssd))
def test_intel_ssd(self):
Expand Down
Loading