Skip to content

Revert "Fix UnicodeDecodeError in xcvr API for corrupted EEPROM (#633)" #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpit-nexthop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Fix UnicodeDecodeError in xcvr API for corrupted EEPROM (#633)" #661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sonic_platform_base/sonic_xcvr/xcvr_api_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ def _get_vendor_name(self):
name_data = self.reader(VENDOR_NAME_OFFSET, VENDOR_NAME_LENGTH)
if name_data is None:
return None
vendor_name = name_data.decode('utf-8', errors='ignore')
vendor_name = name_data.decode()
return vendor_name.strip()

def _get_vendor_part_num(self):
part_num = self.reader(VENDOR_PART_NUM_OFFSET, VENDOR_PART_NUM_LENGTH)
if part_num is None:
return None
vendor_pn = part_num.decode('utf-8', errors='ignore')
vendor_pn = part_num.decode()
return vendor_pn.strip()

def _create_cmis_api(self):
Expand Down
Loading