add cpo bailly xcvr cmis by KroosMicas · Pull Request #672 · sonic-net/sonic-platform-common

KroosMicas · 2026-05-22T03:22:42Z

Description

Add CPO Bailly-related CMIS APIs/MEM maps/Code/Fields as well as the CPO management base class

Motivation and Context

Run Bailly using the community framework

How Has This Been Tested?

Additional Information (Optional)

mssonicbld · 2026-05-22T03:22:51Z

/azp run

azure-pipelines · 2026-05-22T03:23:00Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-22T08:35:18Z

/azp run

azure-pipelines · 2026-05-22T08:35:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-22T08:46:14Z

/azp run

azure-pipelines · 2026-05-22T08:46:24Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T02:56:43Z

/azp run

azure-pipelines · 2026-05-25T02:56:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T03:33:23Z

/azp run

azure-pipelines · 2026-05-25T03:33:31Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T05:47:16Z

/azp run

azure-pipelines · 2026-05-25T05:47:26Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T06:02:44Z

/azp run

azure-pipelines · 2026-05-25T06:02:53Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T06:17:00Z

/azp run

azure-pipelines · 2026-05-25T06:17:09Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-25T06:58:54Z

/azp run

azure-pipelines · 2026-05-25T06:59:03Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-26T07:31:45Z

/azp run

azure-pipelines · 2026-05-26T07:31:55Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-05-30T10:42:13Z

/azp run

azure-pipelines · 2026-05-30T10:42:21Z

Azure Pipelines successfully started running 1 pipeline(s).

prgeor

@KroosMicas are we aligned to the latest design?

KroosMicas · 2026-06-02T02:11:17Z

@KroosMicas are we aligned to the latest design?

Yes, for memmap, we have implemented it using the latest single-page approach. And it has been fully verified through the latest optical driver.

AndrewQu-Micas

changes are good

AndrewQu-Micas

changes are good.

Copilot

Pull request overview

Adds Bailly CPO (ELS) support to sonic_platform_common’s transceiver framework by introducing Bailly-specific CMIS extensions (codes, fields, memory map, and API) plus a new CPO Optoe base class and unit tests.

Changes:

Add Bailly-specific CMIS extensions: codes (BaillyCodes), fields/constants (bailly_consts), and memory map (BaillyMemMap).
Add Bailly-specific API (BaillyApi) that extends CMIS behavior and augments get_transceiver_info().
Add a new CpoOptoeBase helper and unit tests for the new Bailly components; update packaging list in setup.py.

Reviewed changes

Copilot reviewed 8 out of 12 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
tests/sonic_xcvr/test_bailly_optoe_base.py	New unit tests for `CpoOptoeBase` JSON/config, EEPROM access, and presence logic
tests/sonic_xcvr/test_bailly_cmis.py	New unit tests for `BaillyApi`/`BaillyCodes` (includes a broken patch target needing fixes)
sonic_platform_base/sonic_xcvr/mem_maps/bailly/bailly_mem_map.py	New Bailly CMIS page definitions (B0/B1/B2) and memory map class
sonic_platform_base/sonic_xcvr/mem_maps/bailly/init.py	Package init for Bailly mem maps
sonic_platform_base/sonic_xcvr/fields/bailly/bailly_consts.py	New Bailly field name constants used by mem map/API
sonic_platform_base/sonic_xcvr/fields/bailly/init.py	Package init for Bailly fields
sonic_platform_base/sonic_xcvr/codes/bailly/bailly_codes.py	New Bailly code dictionaries (identifiers, interfaces, laser-related enums)
sonic_platform_base/sonic_xcvr/codes/bailly/init.py	Package init for Bailly codes
sonic_platform_base/sonic_xcvr/bailly_optoe_base.py	New CPO Optoe base class and cpo.json reader (has several robustness issues)
sonic_platform_base/sonic_xcvr/api/bailly/bailly_api.py	New Bailly API extending CMIS and enriching transceiver info
sonic_platform_base/sonic_xcvr/api/bailly/init.py	Package init for Bailly API
setup.py	Register new Bailly packages for distribution

prgeor · 2026-06-04T03:00:54Z

@KroosMicas this is NOT aligned with the design. but we should fix this later.

linux-foundation-easycla · 2026-06-04T09:03:07Z

✅ login: Griffin-micas / name: Griffin Gao (815e823)
✅ login: KroosMicas / name: KroosMicas (88b158f)
❌ - login: @Copilot / name: Copilot Autofix powered by AI. The commit (88b158f) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

mssonicbld · 2026-06-04T09:03:07Z

/azp run

azure-pipelines · 2026-06-04T09:03:16Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Kroos <kroos@micasnetworks.com>

mssonicbld · 2026-06-04T09:20:41Z

/azp run

azure-pipelines · 2026-06-04T09:20:51Z

Azure Pipelines successfully started running 1 pipeline(s).

prgeor

@KroosMicas where is the RLM API and memory map?

KroosMicas · 2026-06-05T01:34:53Z

@KroosMicas where is the RLM API and memory map?
@prgeor Newly added content within bailly_mem_map.py and bailly_api.py is mostly ELS-related, while OE leverages the existing CmisMemMap and CmisApi.

prgeor

@KroosMicas agreed that the code will be re-arranged later.

Signed-off-by: Kroos <kroos@micasnetworks.com> Co-authored-by: Griffin Gao <griffin@micasnetworks.com>

yejianquan · 2026-06-09T10:32:08Z

Hi @vaibhavhd , could you please back port this commit to 202605 ,it's a key change of CPO Bailly, and is safe to other non-CPO devices

mssonicbld · 2026-06-09T19:03:39Z

Cherry-pick PR to 202605: #689

mssonicbld · 2026-06-12T20:13:45Z

@KroosMicas cherry pick PR didn't pass PR checker after retry. Please help check! Thanks.
#689

_{---Powered by SONiC BuildBot}

micas-net reviewed May 22, 2026

View reviewed changes

Comment thread sonic_platform_base/sonic_xcvr/bailly_optoe_base.py

KroosMicas force-pushed the master branch from fad1e80 to e489c8c Compare May 22, 2026 08:35

KroosMicas force-pushed the master branch from e489c8c to 5b21d8a Compare May 22, 2026 08:46

KroosMicas force-pushed the master branch from 5b21d8a to 6e93a4d Compare May 25, 2026 02:56

KroosMicas force-pushed the master branch from 6e93a4d to 1894db3 Compare May 25, 2026 03:33

KroosMicas force-pushed the master branch from 1894db3 to 187d624 Compare May 25, 2026 05:47

KroosMicas force-pushed the master branch from 187d624 to cf06df6 Compare May 25, 2026 06:02

KroosMicas force-pushed the master branch from cf06df6 to ab5134d Compare May 25, 2026 06:16

KroosMicas force-pushed the master branch from ab5134d to 07f549d Compare May 25, 2026 06:58

KroosMicas force-pushed the master branch from 07f549d to bb61829 Compare May 26, 2026 07:31

prgeor reviewed Jun 1, 2026

View reviewed changes

AndrewQu-Micas approved these changes Jun 3, 2026

View reviewed changes

prgeor requested a review from Copilot June 4, 2026 01:14

Copilot started reviewing on behalf of prgeor June 4, 2026 01:14 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

prgeor reviewed Jun 4, 2026

View reviewed changes

add cpo bailly xcvr cmis

61e0d1c

Signed-off-by: Kroos <kroos@micasnetworks.com>

KroosMicas force-pushed the master branch from 88b158f to 61e0d1c Compare June 4, 2026 09:20

prgeor reviewed Jun 4, 2026

View reviewed changes

prgeor approved these changes Jun 5, 2026

View reviewed changes

prgeor merged commit 0b5b4a6 into sonic-net:master Jun 5, 2026
6 checks passed

AnoopKamath pushed a commit to AnoopKamath/sonic-platform-common that referenced this pull request Jun 9, 2026

add cpo bailly xcvr cmis (sonic-net#672)

cb70fcc

Signed-off-by: Kroos <kroos@micasnetworks.com> Co-authored-by: Griffin Gao <griffin@micasnetworks.com>

AnoopKamath pushed a commit to AnoopKamath/sonic-platform-common that referenced this pull request Jun 9, 2026

add cpo bailly xcvr cmis (sonic-net#672)

7bfedd5

Signed-off-by: Kroos <kroos@micasnetworks.com> Co-authored-by: Griffin Gao <griffin@micasnetworks.com>

yejianquan added the Request for 202605 Branch label Jun 9, 2026

vaibhavhd added the Approved for 202605 Branch label Jun 9, 2026

mssonicbld mentioned this pull request Jun 9, 2026

[action] [PR:672] add cpo bailly xcvr cmis #689

Open

mssonicbld added the Created PR to 202605 Branch label Jun 9, 2026

Conversation

KroosMicas commented May 22, 2026

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

Uh oh!

mssonicbld commented May 22, 2026

Uh oh!

azure-pipelines Bot commented May 22, 2026

Uh oh!

Uh oh!

mssonicbld commented May 22, 2026

Uh oh!

azure-pipelines Bot commented May 22, 2026

Uh oh!

mssonicbld commented May 22, 2026

Uh oh!

azure-pipelines Bot commented May 22, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 25, 2026

Uh oh!

azure-pipelines Bot commented May 25, 2026

Uh oh!

mssonicbld commented May 26, 2026

Uh oh!

azure-pipelines Bot commented May 26, 2026

Uh oh!

mssonicbld commented May 30, 2026

Uh oh!

azure-pipelines Bot commented May 30, 2026

Uh oh!

prgeor left a comment

Choose a reason for hiding this comment

Uh oh!

KroosMicas commented Jun 2, 2026

Uh oh!

AndrewQu-Micas left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewQu-Micas left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prgeor Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

KroosMicas commented Jun 5, 2026 •

edited

Loading