ci: download libnexthopgroup deb for the sonic-swss build stage#1197
Closed
bhouse-nexthop wants to merge 1 commit into
Closed
ci: download libnexthopgroup deb for the sonic-swss build stage#1197bhouse-nexthop wants to merge 1 commit into
bhouse-nexthop wants to merge 1 commit into
Conversation
sonic-swss commit e6c482ca ("[fpmsyncd]: add libnexthopgroup in
Makefile.am to support rib/fib") added -lnexthopgroup to fpmsyncd's
link line, expecting libnexthopgroup_*.deb to already be installed
when the swss build runs. sonic-swss-common's downstream "Compile
sonic swss" stage installs everything it needs from the common-lib
artifact, but its pattern list never picked up the new package, so
the link now fails with `cannot find -lnexthopgroup`. Add the
libnexthopgroup pattern next to the other Azure.sonic-buildimage.
common_libs entries in build-swss-template.yml so dpkg picks it up
in the existing install step.
Signed-off-by: Brad House <bhouse@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
#973 merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
sonic-swss commit
e6c482ca("[fpmsyncd]: add libnexthopgroup in Makefile.am to support rib/fib", PR sonic-net/sonic-swss#4394) added-lnexthopgrouptofpmsyncd's link line, expectinglibnexthopgroup_*.debto already be installed when the swss build runs. sonic-swss-common's downstream "Compile sonic swss" stage in.azure-pipelines/build-swss-template.ymlinstalls everything it needs from the common-lib artifact, but its pattern list never picked up the new package, so the link now fails withcannot find -lnexthopgroupwhenever this pipeline cascades into a sonic-swss build.Fix: add the
libnexthopgroup*.debpattern next to the otherAzure.sonic-buildimage.common_libsentries sodpkgpicks it up in the existing install step.Reviewer entry point:
.azure-pipelines/build-swss-template.yml(one-line addition).Fixes # (no issue filed)
Type of change
Approach
What is the motivation for this PR?
Unblock the sonic-swss build stage of the sonic-swss-common pipeline, which is currently failing at fpmsyncd's link step on any PR that cascades into a sonic-swss build.
How did you do it?
Added one pattern (
libnexthopgroup*.deb) to the existingDownloadPipelineArtifact@2step that pullscommon_libsfromAzure.sonic-buildimage. The deb is built upstream by sonic-buildimage and already present in the artifact; the pipeline just wasn't asking for it.How did you verify/test it?
Local verification: confirmed via the failing build log that
fpmsyncdis linking against-lnexthopgroupand failing because the lib isn't present on the build agent. CI re-run on this PR will exercise the fix end-to-end.Any platform specific information?
None. The pattern is parameterized by
${{ parameters.debian_version }}like every other entry in the same list.Documentation
N/A — CI plumbing only, no public-facing change.