Fix sonic-swss-common build#1206
Merged
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
bgallagher-nexthop
force-pushed
the
fix-ci
branch
from
bfd7e9e to
213334c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR applies a short-term CI workaround in sonic-swss-common to unblock compilation when the build pipeline lacks the python3-libyang bindings, by installing the libyang Python CFFI bindings from PyPI after installing the libyang3 Debian packages.
Changes:
- Install
libyang==3.3.0viapip3in the Azure pipeline after installing downloaded.debartifacts. - Add inline rationale comments explaining why the PyPI install is needed.
Contributor
Author
|
Resolving Copilot feedback: this is intentionally a short-term fix. The "proper" fix is in sonic-buildimage PR sonic-net/sonic-buildimage#27836 but after merging, sonic-swss-common builds will still fail until the next periodic full build completes and publishes the right packages we need. This PR can be reverted once that has happened. |
yxieca
approved these changes
Jun 13, 2026
Collaborator
|
Cherry-pick PR to 202605: #1209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Motivation
I noticed that the sonic-swss-common build is failing during compilation because libyang python dependencies are not correctly installed by the build pipeline prior to attempting to compile.
This PR contains a short-term fix. The proper fix is in sonic-buildimage (sonic-net/sonic-buildimage#27836), but won't resolve the problem until the next nightly build fires and publishes the correct packages. This PR can be reverted once that fix takes effect.
Testing
The compilation step in the build pipeline now works as expected: https://dev.azure.com/mssonic/build/_build/results?buildId=1136291&view=logs&j=a5b8631f-d2a8-5bf4-c5b7-ed5dd46e146c&t=b99e062e-9dda-5ff0-ad0b-d7a7533b64b9