pddf fanutil improvments#4637
Draft
caleb-nexthop wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Caleb <caleb@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Improved fan CLI output so unpopulated fan slots no longer report misleading values. Absent fans now show N/A, and pddf_fanutil getspeed also shows duty cycle.
How I did it
Used the existing PSU power-good/output status and combined it with presence and input-voltage information to classify PSUs more accurately. Shared that classification between psushow and fanshow so absent, unpowered, faulted, and healthy PSUs are displayed consistently.
How to verify it
Run sudo pddf_fanutil getspeed and confirm unpopulated fans show N/A instead of 0 or stray RPM values. Run show platform fan and confirm absent fans show Not Present / Not Installed with N/A for non-applicable fields.
Previous command output (if the output of a command-line utility has changed)
sudo pddf_fanutil getspeed would not show DUTY Cycle. This could be confusing as setspeed uses duty cycle.
Also, show plat fan would display speeds and details for an uninstalled fan that is not relevant.
Also not installed fans would display NOT OK - similar to if there was a fault.
New command output (if the output of a command-line utility has changed)