core: support tf_half_pixel_for_nn resize coordinate mode - #2595
Merged
Conversation
Collaborator
Author
|
/ci full |
|
🔴 Bench vs main — 1 speed regression(s) · Reference: 2026-08-06 morning nightly run (0d old) · full report → run Speed — evaltime · prefill · decode
|
| Δ | metric | device | main → PR |
|---|---|---|---|
| arm_ml_kws_cnn_m load · pass |
cortex-a9 |
83 ms → 111 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a9 |
129 ms → 167 ms | |
| arm_ml_kws_cnn_m load · pass |
cortex-a7 |
79 ms → 90 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a7 |
119 ms → 133 ms | |
| hey_snips_v4_model17_nnef load · pulse8 |
cortex-a55 |
382 ms → 410 ms | |
| hey_snips_v4_model17_nnef load · pulse8 |
cortex-a53 |
471 ms → 504 ms | |
| en_tdnn_15M_nnef load · pulse_240ms |
cortex-a53 |
452 ms → 480 ms |
❌ CI / full: failure
|
Resize rejected the legacy tf_half_pixel_for_nn coordinate transformation mode, so ONNX models using it failed to build. Add it to CoordTransformer as a length-independent, ROI-free coordinate map ((x + 0.5) / scale).
Collaborator
Author
|
|
kali
force-pushed
the
fix/resize-tf-half-pixel-for-nn
branch
from
August 6, 2026 11:13
ac98271 to
6448d4f
Compare
Collaborator
Author
|
/ci full |
Contributor
|
🔴 Bench vs main — 2 speed regression(s) · Reference: 2026-08-06 morning nightly run (0d old) · full report → run Speed — evaltime · prefill · decode
|
| Δ | metric | device | main → PR |
|---|---|---|---|
| arm_ml_kws_cnn_m load · pass |
cortex-a9 |
83 ms → 100 ms | |
| hey_snips_v4_model17 load · 2sec |
cortex-a7 |
4.31 s → 5.06 s | |
| hey_snips_v4_model17 load+optimize · 2sec |
cortex-a7 |
5.04 s → 5.81 s | |
| hey_snips_v31 load+optimize · 400ms |
cortex-a7 |
381 ms → 438 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a9 |
129 ms → 148 ms | |
| hey_snips_v31 load · 400ms |
cortex-a7 |
334 ms → 383 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a53 |
74 ms → 82 ms | |
| arm_ml_kws_cnn_m load · pass |
cortex-a53 |
48 ms → 53 ms | |
| hey_snips_v31 load · 400ms |
cortex-a9 |
298 ms → 322 ms | |
| hey_snips_v31 load+optimize · 400ms |
cortex-a9 |
343 ms → 369 ms | |
| en_tdnn_15M_nnef load · pulse_240ms |
cortex-a53 |
452 ms → 483 ms | |
| hey_snips_v4_model17_nnef load · pulse8 |
cortex-a53 |
471 ms → 503 ms |
Resize-10 has no coordinate_transformation_mode and is defined as asymmetric, but the importer left the opset-11 default of half_pixel, so opset-10 models resampled on the wrong grid. Force asymmetric in resize_10. Also gate, via since: in the onnx suite node list, a few ONNX 1.5.0/1.6.0 resize conformance tests whose bundled models predate or contradict the nearest attributes their reference outputs assume.
Collaborator
Author
|
/ci full |
|
Reference: 2026-08-06 morning nightly run (0d old) · full report → run Speed — evaltime · prefill · decode no inference-speed regressions
|
| Δ | metric | device | main → PR |
|---|---|---|---|
| arm_ml_kws_cnn_m load · pass |
cortex-a9 |
83 ms → 107 ms | |
| arm_ml_kws_cnn_m load+optimize · pass |
cortex-a9 |
129 ms → 157 ms | |
| hey_snips_v4_model17_nnef load · pulse8 |
cortex-a55 |
382 ms → 426 ms | |
| hey_snips_v4_model17_nnef load · pulse8 |
cortex-a53 |
471 ms → 504 ms | |
| en_tdnn_15M_nnef load · pulse_240ms |
cortex-a53 |
452 ms → 483 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resize rejected the legacy tf_half_pixel_for_nn coordinate transformation mode, so ONNX models using it failed to build. Add it to CoordTransformer as a length-independent, ROI-free coordinate map ((x + 0.5) / scale).