Show source tree size in backup stats#300
Open
kimjune01 wants to merge 2 commits into
Open
Conversation
Add test showing that BackupStats should track source tree sizes: - Total source bytes across all files - Bytes in new files - Bytes in modified files - Bytes in unchanged files Test currently fails because these fields don't exist in BackupStats.
Track and display source file sizes broken down by: - Total bytes across all source files - Bytes in unchanged files - Bytes in new files - Bytes in modified files Resolves sourcefrog#115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backup stats previously showed deduplication and compression metrics but omitted the source tree size, making it hard to understand what percentage of data was being saved. This adds four new metrics: total source bytes and breakdowns for unchanged, modified, and new files.
The size is read once per file and accumulates into the appropriate counter based on whether the file is new, modified, or unchanged. Test coverage confirms the stats track correctly across incremental backups.
Fixes #115.