Open
Conversation
ctb
reviewed
Sep 19, 2024
| help="disable Y axis labels" | ||
| ) | ||
| subparser.add_argument( | ||
| "--sort-by-category", action="store_true", |
Contributor
There was a problem hiding this comment.
Suggested change
| "--sort-by-category", action="store_true", | |
| "--sort-rows-by-category", action="store_true", |
You could imagine we might want to sort cols by category too ;)
Contributor
There was a problem hiding this comment.
(so having this be --sort-rows... leaves that option open - not that we need to implement it now)
ctb
reviewed
Sep 19, 2024
|
|
||
| # optional sorting samples by category | ||
| if args.sort_by_category: | ||
| query_d = manysearch_rows_to_index(rows, column_name='query_name') |
Contributor
There was a problem hiding this comment.
code looks good! can you move into a separate function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added --sort-by-category to clustermap1. Instead of clustering the rows (samples) we can sort them by a category (treatment, or something else).
@ctb ready for review