[codex] Fix PR27 Android audit regressions - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JadxConfigpositional compatibility by keepingextra_argsin its original slotMODE_WORLD_*numeric mode constants passed toopenFileOutput/getSharedPreferencesReview notes
PR #27 was already merged, so this branch is based on the merged
mainstate and addresses follow-up review findings from that diff.Verification
python3 -m unittest sample.tests.test_jadx_runner sample.tests.test_smali_audit sample.tests.test_analysis_cache sample.tests.test_cli_android_audit sample.tests.test_android_pipelinepython3 -m unittest discover -s sample/testsgit diff --check