Skip to content

[codex] Fix PR27 Android audit regressions - #28

Merged
sp3arm4n merged 1 commit into
mainfrom
codex/pr27-review-fixes
May 12, 2026
Merged

[codex] Fix PR27 Android audit regressions#28
sp3arm4n merged 1 commit into
mainfrom
codex/pr27-review-fixes

Conversation

@sp3arm4n

Copy link
Copy Markdown
Owner

Summary

  • bump Android analysis cache schema so pre-smali-tier rows cannot replay without new smali findings
  • preserve JadxConfig positional compatibility by keeping extra_args in its original slot
  • detect smali MODE_WORLD_* numeric mode constants passed to openFileOutput / getSharedPreferences
  • write Android JSON outputs as UTF-8 explicitly

Review notes

PR #27 was already merged, so this branch is based on the merged main state and addresses follow-up review findings from that diff.

Verification

  • python3 -m unittest sample.tests.test_jadx_runner sample.tests.test_smali_audit sample.tests.test_analysis_cache sample.tests.test_cli_android_audit sample.tests.test_android_pipeline
  • python3 -m unittest discover -s sample/tests
  • git diff --check

@sp3arm4n
sp3arm4n marked this pull request as ready for review May 12, 2026 17:08
@sp3arm4n
sp3arm4n merged commit d0d837b into main May 12, 2026
4 checks passed
@sp3arm4n
sp3arm4n deleted the codex/pr27-review-fixes branch May 12, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant