Allow gix versions through 0.70#501
Conversation
spenserblack
left a comment
There was a problem hiding this comment.
Looks good, just need to fix the upper bound.
This would have been covered by scheduled dependabot updates. If there's any particular urgency for this change, I can get out a release quickly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 71.20% 71.20%
=======================================
Files 18 18
Lines 521 521
=======================================
Hits 371 371
Misses 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Highest tested version is 0.70; we did not mean to allow 0.71. Co-authored-by: Spenser Black <spenserblack01@gmail.com>
I don’t think so. I opened this because I was patching the It is true that the releases associated with |
|
Cool! So you've been helping package this project for Fedora? |
|
@all-contributors add @musicinmybrain for platform |
|
I've put up a pull request to add @musicinmybrain! 🎉 |
Yes, I’m now maintaining a (I also maintain |
|
Got it, thanks for your support! I don't know much about authoring packages for Fedora, but let me know if you would ever like a new release. The release process is very trivial on my end, so I'm happy to release as requested. |
This just expands the range of allowed
gixversions to include 0.69 and 0.70.I confirmed that everything still builds and (having set up the checkout with
git fetch upstream test/javascript:test/javascript)cargo test --workspacestill passes.