WIP implementation of protocol 1.7#303
Draft
SomberNight wants to merge 27 commits into
Draft
Conversation
SomberNight
force-pushed
the
202502_protocol_1_6
branch
2 times, most recently
from
938fde4 to
6370b49
Compare
SomberNight
changed the title
SomberNight
force-pushed
the
202502_protocol_1_6
branch
from
6370b49 to
0bd41f1
Compare
Supposedly it makes a difference (see e.g. [0]), and depending on how batching works it makes sense it would, but during a few full syncs of testnet I've done, it was within measurement error. Still, existing code was already doing this. [0]: https://stackoverflow.com/q/54941342
with the pending db changes, an upgrade is ~as fast as a resync from genesis
now that we have our own txindex
SomberNight
force-pushed
the
202502_protocol_1_6
branch
from
0bd41f1 to
525d000
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
ecdsa
reviewed
Apr 29, 2026
SomberNight
force-pushed
the
202502_protocol_1_6
branch
from
525d000 to
b9abbff
Compare
ecdsa
reviewed
Apr 30, 2026
ecdsa
reviewed
May 2, 2026
|
|
||
| PROTOCOL_MIN = (1, 4) | ||
| # consider bumping Coin.MIN_REQUIRED_DAEMON_VERSION too when releasing a new protocol version | ||
| PROTOCOL_MAX = (1, 6, 0) |
SomberNight
force-pushed
the
202502_protocol_1_6
branch
from
3858c82 to
1303e45
Compare
This will allow looking up which tx spent an outpoint.
In Bitcoin consensus, a txout index is stored as a uint32_t. However, in practice, an output in a tx uses at least 10 bytes (for an OP_TRUE output), so - to exhaust a 2 byte namespace, a tx would need to have a size of at least 2 ** 16 * 10 = 655 KB, - to exhaust a 3 byte namespace, a tx would need to have a size of at least 2 ** 24 * 10 = 167 MB.
notifications not implemented yet
Similar to scripthash statuses, the height of an unconfirmed tx is: - `-1` if it has any unconfirmed parents, - `0` otherwise.
History.get_txnums and History.backup depend on ordering of tx_nums, so we want the lexicographical order (used by leveldb comparator) to match the numerical order.
in a way that works consistently between LevelDB and RocksDB.
SomberNight
force-pushed
the
202502_protocol_1_6
branch
from
1303e45 to
a1f2942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP implementation of spesmilo/electrum-protocol#2