Fix crashes on invalid date data, just give us a zeroed out timestamp. - #49
Open
Subsentient wants to merge 1 commit into
Open
Fix crashes on invalid date data, just give us a zeroed out timestamp.#49Subsentient wants to merge 1 commit into
Subsentient wants to merge 1 commit into
Conversation
chen3feng
added a commit
to chen3feng/adbfs
that referenced
this pull request
Jun 28, 2026
…n#49) Wrap the timestamp parsing in a size check (ymd==3, hm==2) and zero-initialize struct tm, so exotic or error ls output no longer causes out-of-range vector access that crashes the filesystem. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, seems for some reason adb can feed us invalid date data, so better to be on the safe side and graciously give us a bad timestamp, rather than segfault, like it does now.
Thanks!