Skip to content

Upgrade @spree/sdk to 1.1.0 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damianlegawiec merged 3 commits into from
Jun 16, 2026
Merged

Upgrade @spree/sdk to 1.1.0 #160

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7dfed3
Upgrade @spree/sdk to 1.1.0 and migrate custom field rendering.
damianlegawiec Jun 16, 2026
225bbb6
Use product meta_title for page SEO metadata.
damianlegawiec Jun 16, 2026
0474b7b
Address CodeRabbit review feedback on custom field rendering.
damianlegawiec Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@next/third-parties": "^16.1.6",
"@paypal/react-paypal-js": "^9.1.1",
"@sentry/nextjs": "^10.38.0",
"@spree/sdk": "^1.0.0",
"@spree/sdk": "^1.1.0",
"@stripe/react-stripe-js": "^5.6.0",
"@stripe/stripe-js": "^8.7.0",
"@swc/helpers": "^0.5.21",
Expand Down
36 changes: 14 additions & 22 deletions src/components/products/ProductCustomFields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ interface ProductCustomFieldsProps {
customFields?: Array<CustomField>;
}

function normalizeType(type: string): string {
return type.split("::").pop() || type;
}

function renderBooleanValue(
value: unknown,
t: ReturnType<typeof useTranslations<"products">>,
Expand All @@ -18,17 +14,16 @@ function renderBooleanValue(

function renderValue(
field: CustomField,
normalizedType: string,
t: ReturnType<typeof useTranslations<"products">>,
): React.ReactNode {
switch (normalizedType) {
case "Boolean":
switch (field.field_type) {
case "boolean":
return renderBooleanValue(field.value, t);
case "Json":
case "json":
return typeof field.value === "string"
? field.value
: JSON.stringify(field.value);
case "RichText":
case "rich_text":
// Value is admin-authored HTML from the Spree CMS backend (trusted source)
return <span dangerouslySetInnerHTML={{ __html: field.value }} />;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
default:
Expand All @@ -51,19 +46,16 @@ export function ProductCustomFields({
{t("properties")}
</h2>
<dl className="space-y-3">
{customFields.map((field) => {
const type = normalizeType(field.type);
return (
<div key={field.id} className="flex">
<dt className="w-32 shrink-0 text-gray-500 text-sm">
{field.label}
</dt>
<dd className="text-gray-900 text-sm min-w-0">
{renderValue(field, type, t)}
</dd>
</div>
);
})}
{customFields.map((field) => (
<div key={field.id} className="flex">
<dt className="w-32 shrink-0 text-gray-500 text-sm">
{field.label}
</dt>
<dd className="text-gray-900 text-sm min-w-0">
{renderValue(field, t)}
</dd>
</div>
))}
</dl>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/metadata/product.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export async function generateProductMetadata({
return { title: "Product Not Found" };
}

const title = product.name;
const title = product.meta_title || product.name;
const description = product.meta_description
? product.meta_description
: product.description
Expand Down
Loading