This repository was archived by the owner on Apr 5, 2022. It is now read-only.
Changle ConnectController to allow updating existing connections#107
Open
daydev wants to merge 1 commit into
Open
Changle ConnectController to allow updating existing connections#107daydev wants to merge 1 commit into
daydev wants to merge 1 commit into
Conversation
|
@daydev Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I walk user through connection flow, but there's already connection for this user and provider, DuplicateConnectionException is thrown and an old connection isn't replaced with a new one.
This becomes real problem when the old connection is actually expired and so it must be replaced with a new one.
I must therefore invent some additional logic to first remove the old connection, and then add the new one. I must go to this trouble, while there exists perfectly capable updateConnection() method in ConnectionRepository.
I propose changing ConnectController, so it will update existing connection on oauth success callback if such connection already exists and create a new one otherwise.