This repository was archived by the owner on Apr 5, 2022. It is now read-only.
No need to manually force port 80 when X-Forwarded-Port is not specif…#259
Open
codeconsole wants to merge 4 commits into
Open
No need to manually force port 80 when X-Forwarded-Port is not specif…#259codeconsole wants to merge 4 commits into
codeconsole wants to merge 4 commits into
Conversation
…ied. This results in a bug when having X-Forwarded-Proto as https and X-Forwarded-Port not specified. It will produce a URL with https and port 80 appended at the end. This bug is prevelant on the most current App Engine Java Flexible environment. It specified the scheme, but no port which causes the code to fail and redirect to a non-existant url.
… if you were using non-proxied https, it would force you to use http. Now it will default to whatever scheme you currently are using.
…cialAuthenticationService. Add Oath2 proxy fix to Oath1 implementation. Fixes spring-attic#261.
…If you were using non-proxied https, it would force you to use http. Now it will default to whatever scheme you currently are using.
Contributor
Author
|
@habuma please merge |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ied. This results in a bug when having X-Forwarded-Proto as https and X-Forwarded-Port not specified. It will produce a URL with https and port 80 appended at the end. This bug is prevelant on the most current App Engine Java Flexible environment. It specified the scheme, but no port which causes the code to fail and redirect to a non-existant url.