Fix issue#1371 - #1372
Open
jasonjiang9527 wants to merge 3 commits into
Open
Conversation
Author
|
Fix #1371 |
Signed-off-by: jiangteng <1@1.cn>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the thread-safety of FeignHttpMessageConverters lazy initialization to address issue #1371 by preventing races when multiple threads request converters concurrently.
Changes:
- Make the cached
convertersfieldvolatileto ensure safe publication across threads. - Add double-checked locking around converter initialization and only assign the field after the list is fully built/customized.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: jiangteng <1@1.cn>
Comment on lines
+48
to
+67
| for (int i = 0; i < threadCount; i++) { | ||
| executor.submit(() -> { | ||
| try { | ||
| startLatch.await(); // Wait for all threads to be ready | ||
|
|
||
| // First call - triggers initialization | ||
| List<?> firstResult = converters.getConverters(); | ||
| synchronized (results) { | ||
| results.add(firstResult); | ||
| } | ||
|
|
||
| // Second call - should return cached result | ||
| List<?> secondResult = converters.getConverters(); | ||
| assertThat(secondResult).isSameAs(firstResult); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } finally { | ||
| endLatch.countDown(); | ||
| } | ||
| }); |
Comment on lines
+73
to
+76
| // Wait for all threads to complete | ||
| endLatch.await(); | ||
| executor.shutdown(); | ||
|
|
Comment on lines
+128
to
+131
| startLatch.countDown(); | ||
| endLatch.await(); | ||
| executor.shutdown(); | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <20434877+jasonjiang9527@users.noreply.github.com>
pdeneve
reviewed
May 23, 2026
| // TODO: allow disabling of registerDefaults | ||
| builder.registerDefaults(); | ||
| // TODO: check if already added? Howto order? | ||
| synchronized (this.convertersLock) { |
There was a problem hiding this comment.
Is there a specific reason to sync on another object than this?
Author
There was a problem hiding this comment.
all the feign call thread will be blocked if another thread synchronize this but not release
|
Any news? Will this PR be resolved and merged? The bug causes a lot of problems with people need to manually fix their projects as workaround (see #1307). |
|
This is a major production issue for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.