Propagate body-level errors in WebClientStreamableHttpTransport#5774
Open
Planview-JamesK wants to merge 3 commits intospring-projects:mainfrom
Open
Propagate body-level errors in WebClientStreamableHttpTransport#5774Planview-JamesK wants to merge 3 commits intospring-projects:mainfrom
Planview-JamesK wants to merge 3 commits intospring-projects:mainfrom
Conversation
Change onErrorComplete to onErrorResume in WebClientStreamableHttpTransport.sendMessage() so that body-level errors (DataBufferLimitException, parse errors, etc.) emit a synthetic JSON-RPC error response to the handler. This resolves pending responses in McpClientSession immediately instead of hanging until requestTimeout. Fixes modelcontextprotocol/java-sdk#889 Signed-off-by: James Kennedy <james.kennedy@planview.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
WebClientStreamableHttpTransport.sendMessage()encounters a body-level error (e.g.DataBufferLimitException, malformed JSON), theonErrorCompleteoperator silently swallows the error. This leaves the pendingMcpClientSessionresponse unresolved, causing a hang untilrequestTimeout(typically 300 seconds).This PR changes
onErrorCompletetoonErrorResumeso that body-level errors emit a synthetic JSON-RPC error response to the handler, resolving pending responses immediately.This is a forward-port of the same fix applied to the MCP Java SDK:
HttpClientStreamableHttpTransportonmain)0.17.x)Fixes #5775
Fixes modelcontextprotocol/java-sdk#889