Remove repeated def for _appears_truncated#787
Merged
Conversation
Contributor
Author
|
Coming back to this, I just saw that there's another PR trying to fix the same Issue |
Owner
Ahh I just merged your change. It'll override theirs. I'll close their PR pointing at yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove repeated def for _appears_truncated
Description
This error makes backend crash due to the file
apps/backend/app/llm.pyhaving a duplicateddefstatement for function_appears_truncatedwith an empty body.The fix removes the duplicated
defstatement and adds theschema_typeparameter to the original_appears_truncateddefinition`.Type
Proposed Changes
Remove repeated function definition for _appears_truncated
Checklist
Summary by cubic
Fixes a backend crash by removing a duplicate
_appears_truncateddefinition inapps/backend/app/llm.py. Consolidates to a single function and adds theschema_typeparameter (default: "resume") to maintain expected truncation checks.Written for commit 03d06d4. Summary will update on new commits.