Skip to content

Remove repeated def for _appears_truncated#787

Merged
srbhr merged 1 commit into
srbhr:mainfrom
lbagnascom:main
May 5, 2026
Merged

Remove repeated def for _appears_truncated#787
srbhr merged 1 commit into
srbhr:mainfrom
lbagnascom:main

Conversation

@lbagnascom

@lbagnascom lbagnascom commented May 4, 2026

Copy link
Copy Markdown
Contributor

Remove repeated def for _appears_truncated

Description

This error makes backend crash due to the file apps/backend/app/llm.py having a duplicated def statement for function _appears_truncated with an empty body.
The fix removes the duplicated def statement and adds the schema_type parameter to the original _appears_truncated definition`.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

Remove repeated function definition for _appears_truncated

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Summary by cubic

Fixes a backend crash by removing a duplicate _appears_truncated definition in apps/backend/app/llm.py. Consolidates to a single function and adds the schema_type parameter (default: "resume") to maintain expected truncation checks.

Written for commit 03d06d4. Summary will update on new commits.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@lbagnascom

Copy link
Copy Markdown
Contributor Author

Coming back to this, I just saw that there's another PR trying to fix the same Issue
#786

@srbhr srbhr merged commit bc2303b into srbhr:main May 5, 2026
2 checks passed
@srbhr

srbhr commented May 5, 2026

Copy link
Copy Markdown
Owner

Coming back to this, I just saw that there's another PR trying to fix the same Issue
#786

Ahh I just merged your change. It'll override theirs. I'll close their PR pointing at yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants