fix(tailor): expand diff scope and preserve casing (fixes #805)#809
Open
Frankli9986 wants to merge 8 commits into
Open
fix(tailor): expand diff scope and preserve casing (fixes #805)#809Frankli9986 wants to merge 8 commits into
Frankli9986 wants to merge 8 commits into
Conversation
- Filter whitespace-only items in section visibility checks (two-column & single-column) - Restore deepseek 1.3x timeout multiplier in llm.py
Allow AI Tailor to modify more resume sections while preserving original capitalization: Backend: - improver.py: extend _ALLOWED_PATH_PATTERNS with education.description, additional.languages, certificationsTraining, awards - improver.py: refine _is_path_blocked to allow education[i].description while keeping degree/institution/years blocked - improver.py: extend calculate_resume_diff to compare education descriptions, languages, and awards - templates.py: add new PATHS to DIFF_IMPROVE_PROMPT + casing rule - test_apply_diffs.py: add tests for new allowed/blocked paths Frontend: - resume_previewer_context.tsx: expand field_type union with 'language' | 'award' - diff-preview-modal.tsx: add ChangeSection rendering for languages and awards - i18n: add translation keys for languageChanges and awardChanges (en/es/ja/pt-BR/zh) Co-Authored-By: Claude <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/backend/app/services/improver.py">
<violation number="1" location="apps/backend/app/services/improver.py:1341">
P1: New `field_type` values (`language`, `award`) used in `ResumeFieldDiff` construction are not accepted by the schema's `Literal` type.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| for lang_key in new_lang_keys - orig_lang_keys: | ||
| changes.append(ResumeFieldDiff( | ||
| field_path="additional.languages", | ||
| field_type="language", |
Contributor
There was a problem hiding this comment.
P1: New field_type values (language, award) used in ResumeFieldDiff construction are not accepted by the schema's Literal type.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/backend/app/services/improver.py, line 1341:
<comment>New `field_type` values (`language`, `award`) used in `ResumeFieldDiff` construction are not accepted by the schema's `Literal` type.</comment>
<file context>
@@ -1284,7 +1324,65 @@ def calculate_resume_diff(
+ for lang_key in new_lang_keys - orig_lang_keys:
+ changes.append(ResumeFieldDiff(
+ field_path="additional.languages",
+ field_type="language",
+ change_type="added",
+ new_value=new_langs[lang_key],
</file context>
This was referenced Jun 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #805 where the AI Tailor had an overly narrow scope and was losing original capitalization.
Changes
education[i].description[j]— education experience descriptionsadditional.languages— language list reorderingadditional.certificationsTraining— certification list reorderingadditional.awards— awards list reorderingVerification
education.description,languages,awards)education.degree,education.institution,education.years)Fixes #805
Summary by cubic
Expanded Tailor’s diff scope to include education descriptions, languages, certifications, and awards, and added casing preservation so proper nouns and acronyms keep their original capitalization. Fixes #805 and updates the diff preview to show language and award changes.
education[i].description,additional.languages,additional.certificationsTraining, andadditional.awards(reorder only).education.degree,education.institution, andeducation.yearsblocked.Written for commit a2f5788. Summary will update on new commits.
Review in cubic