Issue 75: Autostart of Everything when it's not launched#676
Issue 75: Autostart of Everything when it's not launched#676codingonHP wants to merge 1 commit intosrwi:developfrom
Conversation
|
Hello @srwi |
srwi
left a comment
There was a problem hiding this comment.
Hi @codingonHP, thanks for the contribution and for taking on the oldest unresolved issue. 🙂
I tried your changes and while they do work, there is a small issue: When opening the search window while Everything is not already running in the background, the search UI freezes while Everything is starting up. Because of that I was not able to see the progress bar at all. This may not be as noticable for users who use Everything often (short startup times), but for those who rarely use it, the program will usually start by reindexing the database, which causes the freeze to last much longer.
Instead of adding a new progress bar to the UI, I think you can reuse the existing busy indicator in SearchResultsView. To do that, you can integrate your code into the Initialize method in SearchResultsProvider and set the IsBusy flag to true while Everything is starting up.
| public static class EverythingProcessHelper | ||
| { | ||
| private const string Dll64 = "Everything64.dll"; | ||
| private const string Dll32 = "Everything32.dll"; |
There was a problem hiding this comment.
EverythingToolbar doesn't support 32 bit machines, so you can just remove code related to that.
There was a problem hiding this comment.
Removed code for 32 bit. Thanks
| return; | ||
| } | ||
|
|
||
| string[] possiblePaths = |
There was a problem hiding this comment.
The Everything path should already be stored in settings:
I like your use of fallback values but you may want to prioritize the stored location.
There was a problem hiding this comment.
Prioritized user settings and then fallbacks will follow. Thanks
|
Thanks @srwi for the review. I was off for couple of days. I will check the PR comments |
srwi#75 If Everything is not running then run it in background first.
I have tried adding |
d114bfc to
a25acef
Compare
|
Hi,this is a nice feature, what's stopping the merge? |
Ref: #75
Changes:
EnsureRunning()whenever SearchWindow is Activated