feat(v2): Make ResourceNames::ensure_max_length public

[sbernauer]

Description

I need this helper function to fix a bug in commons-operator: stackabletech/commons-operator#443

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

• Changes are OpenShift compatible
• CRD changes approved
• CRD documentation for all fields, following the style guide.
• Integration tests passed (for non trivial changes)
• Changes need to be "offline" compatible

Reviewer

• Code contains useful comments
• Code contains useful logging statements
• (Integration-)Test cases added
• Documentation added or updated. Follows the style guide.
• Changelog updated
• Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

• Feature Tracker has been updated
• Proper release label has been added

[siegfriedweber]

This constant belongs in kvp::key and should be named MAX_KEY_NAME_LENGTH.

Rather than exposing the value publicly, it might be cleaner to offer a sanitize function that takes a key prefix and name and returns a valid kvp::key::Key.

[sbernauer]

I removed the constant and added the requested function. However, I didn't call it sanitize, as to me that gives off security vibes, but happy to discuss the name :)

[siegfriedweber]

This function was written for resource names, where the assertions always hold. If it's now used to shorten arbitrary strings (which could also come from the user) then you can expect the operator to crash.

That said, I do see the usefulness. I'd suggest making it safe for arbitrary strings (which isn't trivial) and moving it to a string utility module.

[sbernauer]

Moved it into crates/stackable-operator/src/utils/length_enforcement.rs.

which isn't trivial

However, I'm pretty sure I missed something, will test non-asci strings now