-
Notifications
You must be signed in to change notification settings - Fork 56
Onboarding Intake(1/3): Intake Runner #1086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devanshcache
wants to merge
40
commits into
stackitcloud:main
Choose a base branch
from
stackit-intake:onboard-intake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
52dd346
Resolve conflicts
2c59ef1
added example of intake runner
b2fd78e
added datasource for intake runner
c98792c
Add docs
876408d
Update stackit/internal/services/intake/runner/data_source.go
yago-123 47a3237
Remove region field
f292331
Add description to custom endpoint
05ef09d
Adjust fields for resource.go (still missing region)
9419446
Reintroduce region as optional field in data resource
f1ac8b0
Adjust resource implementation and implement review comments
276a883
Reshape resource_acc_test
528f92e
Remove replace directive during name change & complement test checks
e4c8e5d
docs
c0ae83c
lint
bc97118
Adjust resource_test
64819d1
adjust last small tweaks
5e09307
lint
8a42eac
Add missing checks in tests
1ff8d7b
Fix remaining test failing in resource_test.go
7b3ea4c
Adjust destroy function
f7444af
Reestablish tf-plugin-docs to newer version and re-generate docs prop…
bdd95d3
Address review
ae2e875
Small adjustment
9fcce2e
Small adjustment and complete docs
44e192e
lint
336dcba
Use new SDK with region removed from hostname
9afa4d0
Remove computed field from description and labels
e76cfc2
Remove region from resource-min.tf test
ccd0889
Move numerical payloads to variables
097fea4
Remove region from resource-min.tf test
fe76b6a
Replace unnecessary concatenation with sprintf
4afc0b8
Add state fields before starting wait handler & retrieve ctx from Set…
37212aa
Log response during update
3c8523b
Reestablish 'Computed: true' for labels until we agree on a solution
eff162f
Use new SDK API hierarchy
a3a8fc3
Handle empty labels
bbed9ac
Address review comments
7a7032e
Adjust to new config builder func and new client API
4229efd
Rebase
98ab4ae
Lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "stackit_intake_runner Data Source - stackit" | ||
| subcategory: "" | ||
| description: |- | ||
| Datasource for STACKIT Intake Runner. | ||
| --- | ||
|
|
||
| # stackit_intake_runner (Data Source) | ||
|
|
||
| Datasource for STACKIT Intake Runner. | ||
|
|
||
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| data "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| runner_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| } | ||
| ``` | ||
|
|
||
| <!-- schema generated by tfplugindocs --> | ||
| ## Schema | ||
|
|
||
| ### Required | ||
|
|
||
| - `project_id` (String) STACKIT Project ID to which the runner is associated. | ||
| - `runner_id` (String) The runner ID. | ||
|
|
||
| ### Optional | ||
|
|
||
| - `region` (String) The resource region. If not defined, the provider region is used. | ||
|
|
||
| ### Read-Only | ||
|
|
||
| - `description` (String) The description of the runner. | ||
| - `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`region`,`runner_id`". | ||
| - `labels` (Map of String) User-defined labels. | ||
| - `max_message_size_kib` (Number) The maximum message size in KiB. | ||
| - `max_messages_per_hour` (Number) The maximum number of messages per hour. | ||
| - `name` (String) The name of the runner. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| --- | ||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | ||
| page_title: "stackit_intake_runner Resource - stackit" | ||
|
rubenhoenle marked this conversation as resolved.
|
||
| subcategory: "" | ||
| description: |- | ||
| Manages STACKIT Intake Runner. | ||
| --- | ||
|
|
||
| # stackit_intake_runner (Resource) | ||
|
|
||
| Manages STACKIT Intake Runner. | ||
|
|
||
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| resource "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| name = "example-runner" | ||
| region = "eu01" | ||
| description = "An example runner for STACKIT Intake" | ||
| max_message_size_kib = 1024 | ||
| max_messages_per_hour = 1000 | ||
| labels = { | ||
| "env" = "development" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| <!-- schema generated by tfplugindocs --> | ||
| ## Schema | ||
|
|
||
| ### Required | ||
|
|
||
| - `max_message_size_kib` (Number) The maximum message size in KiB. | ||
| - `max_messages_per_hour` (Number) The maximum number of messages per hour. | ||
| - `name` (String) The name of the runner. | ||
| - `project_id` (String) STACKIT Project ID to which the runner is associated. | ||
|
|
||
| ### Optional | ||
|
|
||
| - `description` (String) The description of the runner. | ||
| - `labels` (Map of String) User-defined labels. | ||
| - `region` (String) The resource region. If not defined, the provider region is used. | ||
|
|
||
| ### Read-Only | ||
|
|
||
| - `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`region`,`runner_id`". | ||
| - `runner_id` (String) The runner ID. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| data "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| runner_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| resource "stackit_intake_runner" "example" { | ||
| project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
| name = "example-runner" | ||
| region = "eu01" | ||
| description = "An example runner for STACKIT Intake" | ||
| max_message_size_kib = 1024 | ||
| max_messages_per_hour = 1000 | ||
| labels = { | ||
| "env" = "development" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example still missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done