Skip to content

fix: idempotent lifecycle ops #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgoetz-inovex merged 14 commits into from
Apr 28, 2026
Merged

fix: idempotent lifecycle ops #1303

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
94850ce
fix: handle missing resource ID in Read and graceful delete for non-e…
DominikPildner Mar 18, 2026
087ac06
Merge remote-tracking branch 'intive/main' into fix/idempotent-lifecy…
DominikPildner Mar 18, 2026
2326ba3
fix: add nolint explanation
DominikPildner Mar 18, 2026
ed1b259
feat: apply similar 404 check to every applicable resource type
DominikPildner Mar 31, 2026
6a484b1
Merge remote-tracking branch 'upstream/main' into fix/idempotent-life…
DominikPildner Mar 31, 2026
0e364b8
refactor: use error.as instead of silencing linter
DominikPildner Mar 31, 2026
937cb6e
chore: gofmt
DominikPildner Mar 31, 2026
13fd1c4
feat: update contribution example to match introduced changes
DominikPildner Apr 15, 2026
6d6ef82
fix: add missing 404 handling, fix silent error pass, add missing emp…
DominikPildner Apr 16, 2026
e346938
Merge remote-tracking branch 'upstream/main' into fix/idempotent-life…
DominikPildner Apr 16, 2026
9367f59
Merge remote-tracking branch 'upstream/main' into fix/idempotent-life…
DominikPildner Apr 21, 2026
fdebd5e
Merge remote-tracking branch 'upstream/main' into fix/idempotent-life…
DominikPildner Apr 24, 2026
4c5453b
fix: add missing 404 checks, minor fixes
DominikPildner Apr 28, 2026
782a785
Merge remote-tracking branch 'upstream/main' into fix/idempotent-life…
DominikPildner Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/docs/contribution-guide/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package foo

import (
"context"
"errors"
"fmt"
"net/http"
"strings"

"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
Expand All @@ -13,6 +15,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"
"github.com/hashicorp/terraform-plugin-log/tflog"
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core"
fooUtils "github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/foo/utils"
Expand Down Expand Up @@ -276,12 +279,21 @@ func (r *barResource) Read(ctx context.Context, req resource.ReadRequest, resp *
projectId := model.ProjectId.ValueString()
region := r.providerData.GetRegionWithOverride(model.Region)
barId := model.BarId.ValueString()
if barId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}
ctx = tflog.SetField(ctx, "project_id", projectId)
ctx = tflog.SetField(ctx, "region", region)
ctx = tflog.SetField(ctx, "bar_id", barId)

barResp, err := r.client.GetBar(ctx, projectId, region, barId).Execute()
if err != nil {
if oapiErr, ok := errors.AsType[*oapierror.GenericOpenAPIError](err); ok && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading bar", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down Expand Up @@ -338,6 +350,10 @@ func (r *barResource) Delete(ctx context.Context, req resource.DeleteRequest, re
// Delete existing bar
_, err := r.client.DeleteBar(ctx, projectId, region, barId).Execute()
if err != nil {
if oapiErr, ok := errors.AsType[*oapierror.GenericOpenAPIError](err); ok && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting bar", fmt.Sprintf("Calling API: %v", err))
}

Expand Down
5 changes: 5 additions & 0 deletions stackit/internal/services/alb/applicationloadbalancer/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,11 @@ func (r *applicationLoadBalancerResource) Delete(ctx context.Context, req resour
// Delete Application Load Balancer
_, err := r.client.DefaultAPI.DeleteLoadBalancer(ctx, projectId, region, name).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
errStr := utils.PrettyApiErr(ctx, &resp.Diagnostics, err)
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting Application Load Balancer", fmt.Sprintf("Calling API for delete: %v", errStr))
return
Expand Down
9 changes: 8 additions & 1 deletion stackit/internal/services/authorization/customrole/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,14 @@ func (r *customRoleResource) Read(ctx context.Context, req resource.ReadRequest,

ctx = r.annotateLogger(ctx, &model)

roleResp, err := r.client.GetRoleExecute(ctx, r.resourceType, model.ResourceId.ValueString(), model.RoleId.ValueString())
roleId := model.RoleId.ValueString()
if roleId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}

roleResp, err := r.client.GetRoleExecute(ctx, r.resourceType, model.ResourceId.ValueString(), roleId)
Comment thread
DominikPildner marked this conversation as resolved.
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError

Expand Down
7 changes: 7 additions & 0 deletions stackit/internal/services/authorization/roleassignments/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"errors"
"fmt"
"net/http"
"strings"
"time"

Expand All @@ -15,6 +16,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"
"github.com/hashicorp/terraform-plugin-log/tflog"
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
"github.com/stackitcloud/stackit-sdk-go/services/authorization"

"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/conversion"
Expand Down Expand Up @@ -316,6 +318,11 @@ func (r *roleAssignmentResource) Delete(ctx context.Context, req resource.Delete
// Delete existing project role assignment
_, err := r.authorizationClient.RemoveMembers(ctx, model.ResourceId.ValueString()).RemoveMembersPayload(payload).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, fmt.Sprintf("Error deleting %s role assignment", r.apiName), fmt.Sprintf("Calling API: %v", err))
}

Expand Down
6 changes: 6 additions & 0 deletions stackit/internal/services/cdn/customdomain/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,13 @@ func (r *customDomainResource) Delete(ctx context.Context, req resource.DeleteRe

_, err := r.client.DefaultAPI.DeleteCustomDomain(ctx, projectId, distributionId, name).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Delete CDN custom domain", fmt.Sprintf("Delete custom domain: %v", err))
return
}

ctx = core.LogResponse(ctx)
Expand Down
5 changes: 5 additions & 0 deletions stackit/internal/services/cdn/distribution/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,11 @@ func (r *distributionResource) Read(ctx context.Context, req resource.ReadReques

projectId := model.ProjectId.ValueString()
distributionId := model.DistributionId.ValueString()
if distributionId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}
ctx = tflog.SetField(ctx, "project_id", projectId)
ctx = tflog.SetField(ctx, "distribution_id", distributionId)

Expand Down
18 changes: 18 additions & 0 deletions stackit/internal/services/dns/recordset/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package dns

import (
"context"
"errors"
"fmt"
"net/http"
"strings"

"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
Expand All @@ -17,6 +19,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"
"github.com/hashicorp/terraform-plugin-log/tflog"
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
dns "github.com/stackitcloud/stackit-sdk-go/services/dns/v1api"
"github.com/stackitcloud/stackit-sdk-go/services/dns/v1api/wait"

Expand Down Expand Up @@ -292,12 +295,22 @@ func (r *recordSetResource) Read(ctx context.Context, req resource.ReadRequest,
projectId := model.ProjectId.ValueString()
zoneId := model.ZoneId.ValueString()
recordSetId := model.RecordSetId.ValueString()
if recordSetId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}
ctx = tflog.SetField(ctx, "project_id", projectId)
ctx = tflog.SetField(ctx, "zone_id", zoneId)
ctx = tflog.SetField(ctx, "record_set_id", recordSetId)

recordSetResp, err := r.client.DefaultAPI.GetRecordSet(ctx, projectId, zoneId, recordSetId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading record set", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down Expand Up @@ -417,7 +430,12 @@ func (r *recordSetResource) Delete(ctx context.Context, req resource.DeleteReque
// Delete existing record set
_, err := r.client.DefaultAPI.DeleteRecordSet(ctx, projectId, zoneId, recordSetId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting record set", fmt.Sprintf("Calling API: %v", err))
return
Comment thread
DominikPildner marked this conversation as resolved.
}

ctx = core.LogResponse(ctx)
Expand Down
18 changes: 18 additions & 0 deletions stackit/internal/services/dns/zone/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ package dns

import (
"context"
"errors"
"fmt"
"math"
"net/http"
"regexp"
"strings"

Expand All @@ -24,6 +26,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"
"github.com/hashicorp/terraform-plugin-log/tflog"
"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
dns "github.com/stackitcloud/stackit-sdk-go/services/dns/v1api"
"github.com/stackitcloud/stackit-sdk-go/services/dns/v1api/wait"

Expand Down Expand Up @@ -381,11 +384,21 @@ func (r *zoneResource) Read(ctx context.Context, req resource.ReadRequest, resp

projectId := model.ProjectId.ValueString()
zoneId := model.ZoneId.ValueString()
if zoneId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}
ctx = tflog.SetField(ctx, "project_id", projectId)
ctx = tflog.SetField(ctx, "zone_id", zoneId)

zoneResp, err := r.client.DefaultAPI.GetZone(ctx, projectId, zoneId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading zone", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down Expand Up @@ -501,6 +514,11 @@ func (r *zoneResource) Delete(ctx context.Context, req resource.DeleteRequest, r
// Delete existing zone
_, err := r.client.DefaultAPI.DeleteZone(ctx, projectId, zoneId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting zone", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down
5 changes: 5 additions & 0 deletions stackit/internal/services/edgecloud/instance/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,11 @@ func (i *instanceResource) Read(ctx context.Context, req resource.ReadRequest, r
projectId := model.ProjectId.ValueString()
region := i.providerData.GetRegionWithOverride(model.Region)
instanceId := model.InstanceId.ValueString()
if instanceId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}
Comment thread
DominikPildner marked this conversation as resolved.
ctx = tflog.SetField(ctx, "project_id", projectId)
ctx = tflog.SetField(ctx, "instance_id", instanceId)
ctx = tflog.SetField(ctx, "region", region)
Expand Down
9 changes: 9 additions & 0 deletions stackit/internal/services/git/instance/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,11 @@ func (g *gitResource) Read(ctx context.Context, req resource.ReadRequest, resp *
// Extract the project ID and instance id of the model
projectId := model.ProjectId.ValueString()
instanceId := model.InstanceId.ValueString()
if instanceId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}

// Read the current git instance via id
gitInstanceResp, err := g.client.DefaultAPI.GetInstance(ctx, projectId, instanceId).Execute()
Expand Down Expand Up @@ -325,6 +330,10 @@ func (g *gitResource) Delete(ctx context.Context, req resource.DeleteRequest, re
// Call API to delete the existing git instance.
err := g.client.DefaultAPI.DeleteInstance(ctx, projectId, instanceId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting git instance", fmt.Sprintf("Calling API: %v", err))
return
}
Comment thread
DominikPildner marked this conversation as resolved.
Expand Down
15 changes: 13 additions & 2 deletions stackit/internal/services/iaas/affinitygroup/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package affinitygroup

import (
"context"
"errors"
"fmt"
"net/http"
"regexp"
Expand Down Expand Up @@ -245,6 +246,11 @@ func (r *affinityGroupResource) Read(ctx context.Context, req resource.ReadReque
projectId := model.ProjectId.ValueString()
region := r.providerData.GetRegionWithOverride(model.Region)
affinityGroupId := model.AffinityGroupId.ValueString()
if affinityGroupId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}

ctx = core.InitProviderContext(ctx)

Expand All @@ -254,8 +260,8 @@ func (r *affinityGroupResource) Read(ctx context.Context, req resource.ReadReque

affinityGroupResp, err := r.client.GetAffinityGroupExecute(ctx, projectId, region, affinityGroupId)
if err != nil {
oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped
if ok && oapiErr.StatusCode == http.StatusNotFound {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
Expand Down Expand Up @@ -305,6 +311,11 @@ func (r *affinityGroupResource) Delete(ctx context.Context, req resource.DeleteR
// Delete existing affinity group
err := r.client.DeleteAffinityGroupExecute(ctx, projectId, region, affinityGroupId)
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting affinity group", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down
15 changes: 13 additions & 2 deletions stackit/internal/services/iaas/image/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package image
import (
"bufio"
"context"
"errors"
"fmt"
"net/http"
"os"
Expand Down Expand Up @@ -510,6 +511,11 @@ func (r *imageResource) Read(ctx context.Context, req resource.ReadRequest, resp
projectId := model.ProjectId.ValueString()
region := r.providerData.GetRegionWithOverride(model.Region)
imageId := model.ImageId.ValueString()
if imageId == "" {
// Resource not yet created; ID is unknown.
resp.State.RemoveResource(ctx)
return
}

ctx = core.InitProviderContext(ctx)

Expand All @@ -519,8 +525,8 @@ func (r *imageResource) Read(ctx context.Context, req resource.ReadRequest, resp

imageResp, err := r.client.GetImage(ctx, projectId, region, imageId).Execute()
if err != nil {
oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped
if ok && oapiErr.StatusCode == http.StatusNotFound {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
Expand Down Expand Up @@ -623,6 +629,11 @@ func (r *imageResource) Delete(ctx context.Context, req resource.DeleteRequest,
// Delete existing image
err := r.client.DeleteImage(ctx, projectId, region, imageId).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting image", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down
10 changes: 8 additions & 2 deletions stackit/internal/services/iaas/keypair/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package keypair

import (
"context"
"errors"
"fmt"
"net/http"
"strings"
Expand Down Expand Up @@ -200,8 +201,8 @@ func (r *keyPairResource) Read(ctx context.Context, req resource.ReadRequest, re

keyPairResp, err := r.client.GetKeyPair(ctx, name).Execute()
if err != nil {
oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped
if ok && oapiErr.StatusCode == http.StatusNotFound {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
Expand Down Expand Up @@ -296,6 +297,11 @@ func (r *keyPairResource) Delete(ctx context.Context, req resource.DeleteRequest
// Delete existing key pair
err := r.client.DeleteKeyPair(ctx, name).Execute()
if err != nil {
var oapiErr *oapierror.GenericOpenAPIError
if errors.As(err, &oapiErr) && oapiErr.StatusCode == http.StatusNotFound {
resp.State.RemoveResource(ctx)
return
}
core.LogAndAddError(ctx, &resp.Diagnostics, "Error deleting key pair", fmt.Sprintf("Calling API: %v", err))
return
}
Expand Down
Loading
Loading