Skip to content

feat(iam, secretsmanager): add secretsmanager IAM rolebinding datasources#1416

Open
rubenhoenle wants to merge 1 commit intomainfrom
feat/iam-rolebindings-datasources
Open

feat(iam, secretsmanager): add secretsmanager IAM rolebinding datasources#1416
rubenhoenle wants to merge 1 commit intomainfrom
feat/iam-rolebindings-datasources

Conversation

@rubenhoenle
Copy link
Copy Markdown
Member

@rubenhoenle rubenhoenle commented Apr 23, 2026

Description

relates to STACKITTPR-641

Basically the same as #1388, just for datasources.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle requested a review from a team as a code owner April 23, 2026 09:16
@rubenhoenle rubenhoenle force-pushed the feat/iam-rolebindings-datasources branch from 259f615 to 1880d48 Compare April 24, 2026 09:11
@github-actions
Copy link
Copy Markdown

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.26% (-0.01%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic 11.45% (+2.43%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/rolebindings-testing 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/services/secretsmanager 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 86.47% (+0.42%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic/datasource.go 18.18% (+18.18%) 44 (+44) 8 (+8) 36 (+36) 🎉
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/rolebindings-testing/acc_test_builder.go 0.00% (ø) 27 (+3) 0 27 (+3)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/rolebindings.go 0.00% (ø) 2 (+1) 0 2 (+1)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/services/secretsmanager/instance.go 0.00% (ø) 17 (+8) 0 17 (+8)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/services/secretsmanager/secret_group.go 0.00% (ø) 17 (+8) 0 17 (+8)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils.go 83.33% (+0.83%) 84 (+4) 70 (+4) 14 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.26% (-0.01%) 159 (+1) 2 157 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/generic/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iam/rolebindings/v1/services/secretsmanager/iam_rolebindings_secretsmanager_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant