Skip to content

Add sum_to_zero_matrix type#1506

Merged
WardBrian merged 6 commits intomasterfrom
sum-to-zero-matrix
Apr 7, 2025
Merged

Add sum_to_zero_matrix type#1506
WardBrian merged 6 commits intomasterfrom
sum-to-zero-matrix

Conversation

@WardBrian
Copy link
Copy Markdown
Member

Closes #1505. Needs stan-dev/math#3169 and stan-dev/stan#3342

Submission Checklist

Release notes

Added a new constraint, sum_to_zero_matrix, which is a matrix that sums to zero along both axes.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (e511e97) to head (66ab723).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/Ast_to_Mir.ml 80.76% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1506   +/-   ##
=======================================
  Coverage   89.55%   89.56%           
=======================================
  Files          66       66           
  Lines        9695     9694    -1     
=======================================
  Hits         8682     8682           
+ Misses       1013     1012    -1     
Files with missing lines Coverage Δ
src/frontend/Pretty_printing.ml 92.30% <100.00%> (+0.02%) ⬆️
src/frontend/Ast_to_Mir.ml 93.90% <80.76%> (+0.17%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WardBrian WardBrian marked this pull request as ready for review March 28, 2025 16:31
@WardBrian WardBrian requested a review from SteveBronder March 31, 2025 16:57
Copy link
Copy Markdown
Contributor

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing but besides that all good!

Comment thread test/integration/bad/reserved/stanc.expected
Comment thread src/frontend/Ast_to_Mir.ml Outdated
[%message
"Expecting SVector or SMatrix, got " (st : Expr.Typed.t SizedType.t)]

let rec param_size transform sizedtype =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) can we change the name to transform_sizedtype. I think it makes it more clear what the function does

Comment thread src/frontend/Ast_to_Mir.ml
@WardBrian WardBrian merged commit eaaed9c into master Apr 7, 2025
3 checks passed
@WardBrian WardBrian deleted the sum-to-zero-matrix branch April 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sum to zero matrix

2 participants