Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1506 +/- ##
=======================================
Coverage 89.55% 89.56%
=======================================
Files 66 66
Lines 9695 9694 -1
=======================================
Hits 8682 8682
+ Misses 1013 1012 -1
🚀 New features to boost your workflow:
|
SteveBronder
approved these changes
Apr 7, 2025
Contributor
SteveBronder
left a comment
There was a problem hiding this comment.
One minor thing but besides that all good!
| [%message | ||
| "Expecting SVector or SMatrix, got " (st : Expr.Typed.t SizedType.t)] | ||
|
|
||
| let rec param_size transform sizedtype = |
Contributor
There was a problem hiding this comment.
(minor) can we change the name to transform_sizedtype. I think it makes it more clear what the function does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1505. Needs stan-dev/math#3169 and stan-dev/stan#3342
Submission Checklist
Release notes
Added a new constraint,
sum_to_zero_matrix, which is a matrix that sums to zero along both axes.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)