-
Notifications
You must be signed in to change notification settings - Fork 0
Merge dev into main #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8c9e92a
b0114a7
e3cbdde
1a3c982
6ec010c
cf8bb93
9283095
2791613
3339af9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| #!/bin/bash | ||
|
|
||
| dart run build_runner build --delete-conflicting-outputs | ||
| cd llm && dart run build_runner build --delete-conflicting-outputs | ||
| cd ../mcp && dart run build_runner build --delete-conflicting-outputs | ||
|
|
||
| clear |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| export 'models/conversation.dart'; | ||
| export 'models/message.dart'; | ||
| export 'storage/conversation_storage.dart'; |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,6 @@ | ||||||||
| import 'dart:convert'; | ||||||||
|
|
||||||||
| import 'package:json_annotation/json_annotation.dart'; | ||||||||
| import 'package:multigateway/core/chat/models/message.dart'; | ||||||||
|
|
||||||||
| part 'conversation.g.dart'; | ||||||||
|
|
||||||||
|
|
@@ -11,12 +10,14 @@ class Conversation { | |||||||
| final String title; | ||||||||
| final DateTime createdAt; | ||||||||
| final DateTime updatedAt; | ||||||||
| final List<ChatMessage> messages; | ||||||||
| final List<Map<String, dynamic>> messages; | ||||||||
| final int? tokenCount; | ||||||||
| final String providerId; | ||||||||
| final String modelName; | ||||||||
| final String modelId; | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to other models in this PR, the
Suggested change
|
||||||||
| final String profileId; | ||||||||
|
|
||||||||
| String get modelName => modelId; | ||||||||
|
|
||||||||
| Conversation({ | ||||||||
| required this.id, | ||||||||
| required this.title, | ||||||||
|
|
@@ -25,18 +26,17 @@ class Conversation { | |||||||
| this.messages = const [], | ||||||||
| this.tokenCount, | ||||||||
| required this.providerId, | ||||||||
| required this.modelName, | ||||||||
| required this.modelId, | ||||||||
| required this.profileId, | ||||||||
| }); | ||||||||
|
|
||||||||
| Conversation copyWith({ | ||||||||
| String? title, | ||||||||
| DateTime? updatedAt, | ||||||||
| List<ChatMessage>? messages, | ||||||||
| List<Map<String, dynamic>>? messages, | ||||||||
| int? tokenCount, | ||||||||
| bool? isAgentConversation, | ||||||||
| String? providerId, | ||||||||
| String? modelName, | ||||||||
| String? modelId, | ||||||||
| String? profileId, | ||||||||
| }) { | ||||||||
| return Conversation( | ||||||||
|
|
@@ -47,7 +47,7 @@ class Conversation { | |||||||
| messages: messages ?? this.messages, | ||||||||
| tokenCount: tokenCount ?? this.tokenCount, | ||||||||
| providerId: providerId ?? this.providerId, | ||||||||
| modelName: modelName ?? this.modelName, | ||||||||
| modelId: modelId ?? this.modelId, | ||||||||
| profileId: profileId ?? this.profileId, | ||||||||
| ); | ||||||||
| } | ||||||||
|
|
||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
fieldRename: FieldRename.snakeannotation on the class implies thatmodelIdshould be serialized tomodel_id. However, the generated code usesmodel_name. While this might be intentional for compatibility, it's confusing for future maintenance. To make the intent explicit and remove ambiguity, please add a@JsonKeyannotation.