Skip modules without priv uses when computing unused imports diagnostics

[integraledelebesgue]

Summary

A little optimization for further gain of diagnostic performance in CairoLS

---

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

[reviewable-StarkWare]

This change is 

[integraledelebesgue]

This change is part of the following stack:

• Optimize diagnostics flattening in get_all #9828
  • Skip modules without priv uses when computing unused imports diagnostics #9829 ◀
    • Replace singleton file overrides with granular inputs and views #9830
      • Replace singleton crate configs input with granular inputs and views #9831
        • Replace singleton plugin overrides with granular inputs and views #9835

_{Change managed by git-spice.}

[orizi]

@orizi reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on integraledelebesgue).

---

crates/cairo-lang-semantic/src/db.rs line 378 at r1 (raw file):

            ModuleItemId::Use(use_id) => Some(use_id),
            _ => None,
        })

Suggestion:

        .filter_map(|info| try_extract_matches!(info.item_id, ModuleItemId::Use))

---

crates/cairo-lang-semantic/src/db.rs line 389 at r1 (raw file):

        add_unused_import_diagnostics(db, all_used_uses, use_id, diagnostics);
    }
}

Suggestion:

        })
        .peekable();
    if private_uses.peek().is_none() {
        return;
    }
    let Ok(all_used_uses) = db.module_all_used_uses(module_id) else {
        return;
    };
    for use_id in private_uses {
        add_unused_import_diagnostics(db, all_used_uses, use_id, diagnostics);
    }
}

[piotmag769]

@piotmag769 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on integraledelebesgue).

[Arcticae]

@Arcticae reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on integraledelebesgue).

[piotmag769]

@piotmag769 reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on integraledelebesgue).

[wawel37]

@wawel37 made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on orizi).

---

crates/cairo-lang-semantic/src/db.rs line 378 at r1 (raw file):

            ModuleItemId::Use(use_id) => Some(use_id),
            _ => None,
        })

Done

---

crates/cairo-lang-semantic/src/db.rs line 389 at r1 (raw file):

        add_unused_import_diagnostics(db, all_used_uses, use_id, diagnostics);
    }
}

Done

[orizi]

@orizi made 1 comment and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on integraledelebesgue).

[orizi]

@orizi reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on integraledelebesgue).