Conversation
PR SummaryLow Risk Overview Updates the benchmark harness to use Reviewed by Cursor Bugbot for commit 2c56d92. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c56d92706
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on eytan-starkware and orizi).
bc1be30 to
5852243
Compare
2c56d92 to
219c28e
Compare
5852243 to
6035420
Compare
219c28e to
161110e
Compare

TL;DR
Added two new benchmarks to measure the performance of the lowering cache pipeline for Cairo compilation.
What changed?
Two new benchmark functions were added to the compile benchmark suite:
fib: cairo-to-cache— measures the time to compile Cairo source to a serialized lowering cache (bytes), without Sierra generation.fib: cache-to-sierra— measures the time to generate Sierra from a pre-compiled lowering cache, isolating the cost of Sierra generation from the full compilation pipeline.How to test?
Run the compile benchmarks:
The two new benchmark entries (
fib: cairo-to-cacheandfib: cache-to-sierra) will appear in the output alongside the existing benchmarks.Why make this change?
The lowering cache splits the compilation pipeline into two distinct phases. These benchmarks allow measuring each phase independently, making it possible to quantify the performance impact of caching lowering results and to track regressions or improvements in each phase separately.