Refresh file info counter after deleting a file#6841
Open
dev-null-life wants to merge 1 commit intostashapp:developfrom
Open
Refresh file info counter after deleting a file#6841dev-null-life wants to merge 1 commit intostashapp:developfrom
dev-null-life wants to merge 1 commit intostashapp:developfrom
Conversation
The mutateDeleteFiles Apollo cache update evicted the plural list queries (findScenes/findImages/findGalleries) but not the singular detail queries, so the "File Info" counter on a scene/image/gallery detail page stayed stale until a manual refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "File Info" counter on Scene, Image, and Gallery detail pages did not update after deleting a file — users had to manually refresh to see the new count.
The Apollo
updatehandler inmutateDeleteFileswas evicting the plural list queries (findScenes,findImages,findGalleries) and the file objects themselves, but not the singular detail queries (findScene,findImage,findGallery) that drive the counters on the detail pages. Adding those to theevictQuerieslist triggers a refetch next time the detail page reads the cache.Test plan