Fix: Release DB Lock on Large Image Libraries#6845
Open
Gykes wants to merge 1 commit intostashapp:developfrom
Open
Fix: Release DB Lock on Large Image Libraries#6845Gykes wants to merge 1 commit intostashapp:developfrom
Gykes wants to merge 1 commit intostashapp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cancelling an image phash generation task on a library with more than 200K images, the consumer breaks out of the queue loop while the producer is still inside a read transaction queuing items. Once the 200K buffer fills, the producer blocks on send indefinitely, holding the database lock.
This is untested in a real situation as I don't have that many images. I would request that @BonerFide test this out for me.
fixes: #6842