Add missing (empty) dependency array to useEffect()#6849
Open
megatwig wants to merge 4 commits intostashapp:developfrom
Open
Add missing (empty) dependency array to useEffect()#6849megatwig wants to merge 4 commits intostashapp:developfrom
useEffect()#6849megatwig wants to merge 4 commits intostashapp:developfrom
Conversation
A `useEffect` without a dependency array is re-evaluated on every single render. Most of these are just binding (and unbinding) keyboard shortcuts, so should be pretty safe to update in bulk. I did spot a couple that skip keybind listeners if `!isVisible`, so set as a dependency so they'll still get installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useEffectwithout a dependency array is re-evaluated on every single render.Most of these are just binding (and unbinding) keyboard shortcuts, so should be pretty safe to update in bulk.
I did spot a couple that skip keybind listeners if
!isVisible, so set as a dependency so they'll still get installed.There's an eslint check which can flag this (and other deps issues) - but the version of
eslint-plugin-react-hooksconfigured is ancient and doesn't seem to have it. I briefly tried upgrading and enabling, buteslint-config-airbnbcomplains it's too new, and it surfaces 57 new lint errors (222 with with fullreact-hooks/recommendedenabled).