[9.x] Fix view-only permission not allowing read-only access to records#833
Merged
Conversation
|
Released as part of v9.5.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a user with only the view permission for a Runway resource could see the listing but got a "This action is unauthorized" error when clicking into an individual record.
This was happening because the edit screen authorized against the
editpermission, rather thanview. This differs from how entries work in Statamic core, where a view-only user can open an entry in read-only mode.This PR fixes it by mirroring core's behaviour:
EditRequestnow authorizesviewinstead ofedit, so view-only users can open a record. Saving still requiresedit(viaUpdateRequest), so they can't make changes.readOnlyflag is now alsotruewhen the user can'teditthe model, so the form renders in read-only mode (the "Read Only" badge shows and fields/save are disabled).ResourcePolicy::view()now returnstrueif the user canedit, matching core'sEntryPolicy::view().Fixes #827