-
-
Notifications
You must be signed in to change notification settings - Fork 621
[6.x] Combobox 2.0 #13843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duncanmcclean
wants to merge
49
commits into
6.x
Choose a base branch
from
combobox-2-0
base: 6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[6.x] Combobox 2.0 #13843
Changes from 44 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
98d6c7a
wip
duncanmcclean 5d8863d
wip
duncanmcclean 4237342
wip
duncanmcclean 6157dad
tidy up
duncanmcclean 409fe91
dark mode disabled styling
duncanmcclean bde614e
don't need a min-height now we have a max-height
duncanmcclean f597936
wip
duncanmcclean 4496fd8
clear search query when closing dropdown
duncanmcclean 3069ec0
wip
duncanmcclean b2fe2c1
wip
duncanmcclean e9d5716
fix option hover state
duncanmcclean f0ad342
fix typing space in search term
duncanmcclean 5094246
focus input if its available, otherwise focus the trigger
duncanmcclean 14a5982
wip
duncanmcclean 56624db
truncate text
duncanmcclean 4d4215e
keyboard navigation should start from selected option
duncanmcclean 6f2dc28
accessibility improvements
duncanmcclean 9992939
add opt-in for adaptive widths
duncanmcclean 264711f
reorder props and tweak descriptions
duncanmcclean 959b2ba
Merge branch '6.x' into combobox-2-0
duncanmcclean 3ba80b7
add combobox story & tests
duncanmcclean f06b37e
update select component story to better mirror combobox
duncanmcclean 3a29e6d
wip
duncanmcclean 706d4cc
fix icon
duncanmcclean 7d49995
grabbing cursors
duncanmcclean 86c9281
Merge branch '6.x' into combobox-2-0
duncanmcclean cd22a97
taggable fixes
duncanmcclean 54b0e84
wip
duncanmcclean 1b35468
actually, remove props preventing reka from doing this
duncanmcclean 8581ee7
Fix relationship typeahead...
duncanmcclean a6ba36e
Merge remote-tracking branch 'origin/6.x' into combobox-2-0
duncanmcclean 4a81f90
revert 1b35468a. reka seems to behave slightly differently and it bre…
duncanmcclean a525c25
Merge remote-tracking branch 'origin/6.x' into combobox-2-0
duncanmcclean 819e0f9
wip
duncanmcclean e47ae87
Fix dropdown z-index
duncanmcclean bc78018
Code editor mode select should have adaptive width.
duncanmcclean 659ecb3
Merge branch '6.x' into combobox-2-0
duncanmcclean 487e95d
Merge branch '6.x' into combobox-2-0
duncanmcclean 5c6a6c3
Only use Fuzzysort for search. We want to retain the original order.
duncanmcclean 495b3df
Merge branch '6.x' into combobox-2-0
duncanmcclean e50b4a9
Merge branch '6.x' into combobox-2-0
duncanmcclean 944a192
truncate selected option text in relationship select
duncanmcclean 744d428
Merge branch '6.x' into combobox-2-0
duncanmcclean 0632b95
Merge branch '6.x' into combobox-2-0
duncanmcclean cf194da
fix tags fieldtype
duncanmcclean 2248ef5
fix placeholder text colour
duncanmcclean 85254c2
handle null value on paste
duncanmcclean f417b3d
remove unused parameter
duncanmcclean 6143937
not recommended for large datasets
duncanmcclean File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.