SPIKE: Protocol 28 (CAP-0084)#58
Closed
sisuresh wants to merge 3 commits into
Closed
Conversation
…d_contract Pin stellar-xdr git dep to rs-stellar-xdr#549 head (7b46a60d914c1e5befd6a2d2c50d2fdf7e5eb1f0) with the per-cap feature cap_0084_muxed_contract (+ cap_0083). xdr submodule = stellar-xdr#306 (7b561814…). Branch rebuilt on current main (v27.0.0). Add the CAP-0084 MuxedContract and StellarValueProposedValue variants to the tests/tests.rs type list to match #549's generated TypeVariant list.
Author
|
Downstream lab PR (CAP-0084 SPIKE): stellar/laboratory#2131 |
…dup (SPIKE) The p28-cap-0084 SPIKE pins stellar-xdr to a git rev of rs-stellar-xdr#549, which cargo-deny's `sources` check rejects (unknown-git) and whose newer crate-git-revision (0.0.9) collides with stellar-strkey's 0.0.6 under the `bans` duplicate check. Add SPIKE-only allow-git + skip entries; revert both when rs-stellar-xdr releases and the pin flips from git= to version=.
Author
|
Closing — this stack will be regenerated from scratch by the automated protocol-release flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
stellar-xdrgit dep to rs-stellar-xdr#549 head (7b46a60d914c1e5befd6a2d2c50d2fdf7e5eb1f0, crate v28.0.0); xdr submodule = stellar-xdr#306 (7b561814…).cap_0083+cap_0084_muxed_contract(replaces legacy barecap_0084).MuxedContractandStellarValueProposedValuetotests/tests.rstype list to match #549's generatedTypeVariantlist.wasm-opt = falsewhile on the pre-release dep (binaryen rejects bulk-memory ops); re-enable once the rev lands a release build.main(v27.0.0).cargo build/fmt/test(24 pass) +wasm-pack build --releaseall green locally.Deferred
wasm-pack test --headless --firefox— no local firefox/geckodriver; relying on CI for the wasm test leg.Upstream: stellar/rs-stellar-xdr#549, stellar/stellar-xdr#306
Downstream: stellar/stellar-laboratory (pins
@stellar/stellar-xdr-json)