-
Notifications
You must be signed in to change notification settings - Fork 59
SPIKE: Protocol 28 (CAP-0084) #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sisuresh
wants to merge
15
commits into
stellar:main
Choose a base branch
from
sisuresh:p28-cap-0084
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f0eafaa
Protocol 28 (CAP-0084): muxed contract address support in the SAC
sisuresh fa5473b
Bump stellar-xdr->Y; gate CAP-0084 on umbrella next per contract (dro…
sisuresh 45162cd
Re-pin rs-stellar-xdr to #552 head cf7fdedf (CAP-0084 SPIKE)
sisuresh 6199f74
Gate CAP-0084 on per-cap leaf feature cap_0084_muxed_contract
sisuresh f4a995c
Revert out-of-scope anyhow 1.0.75 -> 1.0.103 bump
sisuresh 83a01f3
Align deny.toml SPIKE breadcrumb with live rs-stellar-xdr #552 pin
sisuresh 84bc47c
cargo-deny: clear anyhow RUSTSEC advisory on CAP-0084 PR
sisuresh ba50c6d
cargo-deny: ignore anyhow RUSTSEC-2026-0190; revert out-of-scope Carg…
sisuresh 55e3098
Cap ed25519-dalek <3.0.0 to keep it aligned with rand 0.8.5
sisuresh 4b4ec35
Add end-to-end muxed-contract storage-key test; dedupe with account case
sisuresh 708b3c4
bump lock file
sisuresh 569a74c
update deny.toml
sisuresh 08d56e0
Remove CAP-0084 feature gates: muxed contract support is unconditional
sisuresh b4aec4e
Merge branch 'main' into p28-cap-0084
sisuresh 128d710
CAP-84: scope muxed contract support to `transfer` only (drop `mint`)
sisuresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...an-env-host/observations/test__address__test_muxed_contract_to_components_conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| " 0 begin": "cpu:0, mem:0, prngs:-/-, objs:-/-, vm:-/-, evt:-, store:-/-, foot:-, stk:-, auth:-/-", | ||
| " 1 call get_address_from_muxed_address(MuxedAddress(obj#1))": "cpu:442, mem:80, objs:-/1@a53ac37b", | ||
| " 2 ret get_address_from_muxed_address -> Ok(Address(obj#3))": "cpu:1110, mem:160, objs:-/2@4b6987b0", | ||
| " 3 call get_id_from_muxed_address(MuxedAddress(obj#1))": "", | ||
| " 4 ret get_id_from_muxed_address -> Ok(U64(456))": "cpu:1230", | ||
| " 5 end": "cpu:1338, mem:160, prngs:-/-, objs:-/2@4b6987b0, vm:-/-, evt:-, store:-/-, foot:-, stk:-, auth:-/-" | ||
| } |
380 changes: 380 additions & 0 deletions
380
...st__stellar_asset_contract__test_cap_84_issuer_transfer_to_muxed_contract_emits_mint.json
Large diffs are not rendered by default.
Oops, something went wrong.
844 changes: 844 additions & 0 deletions
844
...observations/test__stellar_asset_contract__test_cap_84_transfer_with_muxed_contracts.json
Large diffs are not rendered by default.
Oops, something went wrong.
4 changes: 4 additions & 0 deletions
4
soroban-env-host/observations/test__storage__muxed_contract_storage_key_conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| " 0 begin": "cpu:14285, mem:0, prngs:-/9b4a753, objs:-/-, vm:-/-, evt:-, store:-/-, foot:-, stk:-, auth:-/-", | ||
| " 1 end": "cpu:14895, mem:80, prngs:-/9b4a753, objs:-/1@d3ad1bcd, vm:-/-, evt:-, store:-/-, foot:-, stk:-, auth:-/-" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be removed