📊 Refresh Stellar Data Structures#2446
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR refreshes the “Stellar Data Structures” docs section by improving navigation (new sidebar category) and tightening language/linking in the Assets and Events pages to make key references easier to follow.
Changes:
- Added a Docusaurus
_category_.jsonto group the Stellar Data Structures docs under a sidebar category. - Updated
assets.mdxfor clearer asset examples, moved the contract token note closer to relevant content, and formattedint64sas code. - Updated
events.mdxto link directly to the in-pageTransactionMetaV3/V4sections and replaced an outdated SEP-41 redirect with a direct GitHub link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/learn/fundamentals/stellar-data-structures/events.mdx | Improves page metadata/wording and replaces reference-style links with direct in-page anchors; updates SEP-41 link target. |
| docs/learn/fundamentals/stellar-data-structures/assets.mdx | Refines asset description language, relocates the “contract token” note, and formats int64s inline as code. |
| docs/learn/fundamentals/stellar-data-structures/category.json | Adds a sidebar category entry that links to the section README. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
some nitpicks to change, but it's a very good start.
your category file also appears in #2411. we can discuss more about the json file approach there, but if you include this file now, it could easily lead to a conflict down the road.
| # Assets | ||
|
|
||
| Accounts on the Stellar network can be used to track, hold, and transfer any type of asset. Assets can represent many things: cryptocurrencies (such as bitcoin or ether), fiat currencies (such as dollars or pesos), other tokens of value (such as NFTs), pool shares, or bonds and equity. | ||
| Accounts on the Stellar network can be used to track, hold, and transfer any type of asset. Assets can represent many things: cryptocurrencies (such as bitcoin or ether), fiat currencies (such as dollars or pesos), other tokens of value (such as NFTs, pool shares, or securities). |
There was a problem hiding this comment.
i think i like the parenthesis the way it was before. and maybe securities belongs as an addition to bonds and equity rather than a replacement?
There was a problem hiding this comment.
we've been moving away from category json files for these kinds of directories. pretty much anything you need to modify can be done so directly in the README.mdx frontmatter.
Co-authored-by: Elliot Voris <elliot@voris.me>
JFWooten4
changed the title
This PR refreshes the Stellar Data Structures section by adding a sidebar category and tightening the Assets and Events pages.
It updates the Assets page to use clearer language around securities, moves the contract token note closer to the related discussion, and formats
int64sas code.It also updates the Events page description and clarifies the
TransactionMetaV3andTransactionMetaV4references so the page points directly to the relevant inline sections.I also cleaned up the needless duplication of Markdown link references for the inline
TransactionMetapage refs and updated the old SDF site SEP redirects to point directly to the actual GitHub instance.