fix: correct swapped JSON tags on PaginationLinks Prev/Next fields#615
Open
SAY-5 wants to merge 1 commit into
Open
fix: correct swapped JSON tags on PaginationLinks Prev/Next fields#615SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
aristidesstaffieri
approved these changes
May 14, 2026
aristidesstaffieri
left a comment
aristidesstaffieri
left a comment
Contributor
There was a problem hiding this comment.
@SAY-5 thanks for the contribution!
Author
|
The |
Author
|
Anything else needed from my side here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593.
internal/entities/pagination.gohad thePrevandNextfield tagsswapped, so any code that populated
PaginationLinksby Go field nameemitted cursors under the wrong JSON key. The struct is currently unused
in this repository, so swapping the tags to match the field names has no
wire-format impact today.
Added a round-trip JSON test in
internal/entities/pagination_test.gothat fails on the previous (swapped) tags and passes on the fix.