Skip to content

Added messagetype 0x14 and 0x15 for file-access. #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OliverDDS wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added messagetype 0x14 and 0x15 for file-access. #407

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
452a9b0
Added functions 0x14 and 0x15 ( read and write general-reference )
Nov 7, 2017
1dece16
Added documentation for new functions 0x14 and 0x15 and new mappings …
Nov 7, 2017
41d3f3a
Added test for functions 0x14 and 0x15 and mappings of file-registers
Nov 7, 2017
455f7cb
Improved commandline for tests, devicenames and baudrate of rtu-test …
Nov 7, 2017
54ca527
Changed c++ comments to c-style
Nov 8, 2017
ad8f21c
Changed naming to write+read file record and _sub_req_hdr_length
Nov 8, 2017
f529251
Changed naming of define for maximum record-files to MODBUS_MAX_RECOR…
Nov 8, 2017
034b24c
Updated documentation to new function-names and defines
Nov 8, 2017
4497392
Increased number of files to 0xffff, due to review finding, removed c…
Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/modbus-private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ MODBUS_BEGIN_DECLS
#define _RESPONSE_TIMEOUT 500000
#define _BYTE_TIMEOUT 500000

#define SUB_REQUEST_LENGHT 0x07
Copy link
Copy Markdown
Contributor

@mhei mhei Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the typo, I would prefer: _SUB_REQ_HDR_LENGTH

#define SUB_REQUEST_REF_TYPE \
0x06 // Reference-Type for General Reference Read + Write

Copy link
Copy Markdown
Contributor

@mhei mhei Nov 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project uses usually C style comments, not C++ styles ones like this one.

typedef enum {
_MODBUS_BACKEND_TYPE_RTU=0,
_MODBUS_BACKEND_TYPE_TCP
Expand Down
Loading