(Closes #3415) Avoid nested ArrayTypes on StructureType types#3439
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3439 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 391 391
Lines 54668 54659 -9
=======================================
- Hits 54649 54640 -9
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@sergisiso This is ready for a first look, I'm hoping this is simple enough. |
sergisiso
approved these changes
May 21, 2026
Collaborator
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 I agree with the fix and it has passed all test, this is approved for merging.
Collaborator
|
@LonelyCat124 Oh before merging, there are 4 todos in other tests that now can be clean up. Could you do that before we close the issue? |
Collaborator
Author
|
@sergisiso Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.